linux-kernel - Re: [PATCH v3 08/10] x86/cpufeatures: Add feature bits for AMD heterogeneous processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240611105216.GAZmgsYC-J_yLfdupF@fat_crate.local>
Date: Tue, 11 Jun 2024 12:52:27 +0200
From: Borislav Petkov <bp@...en8.de>
To: Perry Yuan <perry.yuan@....com>
Cc: Mario.Limonciello@....com, gautham.shenoy@....com,
	rafael.j.wysocki@...el.com, viresh.kumar@...aro.org,
	Ray.Huang@....com, Alexander.Deucher@....com, Xinmei.Huang@....com,
	Xiaojian.Du@....com, Li.Meng@....com, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 08/10] x86/cpufeatures: Add feature bits for AMD
 heterogeneous processor

On Tue, Jun 11, 2024 at 04:52:24PM +0800, Perry Yuan wrote:
> Subject: Re: [PATCH v3 08/10] x86/cpufeatures: Add feature bits for AMD heterogeneous processor

"... Add a heterogeneous core topology feature bit"

not "feature bits"

> CPUID leaf 0x80000026 advertises core types with different efficiency rankings
> 
> Bit 30 indicates the heterogeneous core topology feature, if the bit
> set, it means not all instances at the current hierarchical level have
> the same core topology.
> 
> For better utilization of feature words and help to identify core type,
> X86_FEATURE_HETERO_CORE_TOPOLOGY is added as a few scattered feature bits.

This sentence is not needed.

> PDF p274
> 
> Link: https://www.amd.com/content/dam/amd/en/documents/processor-tech-docs/programmer-references/24593.pdf

This link will become obsolete, you can say instead

Search the web for "architecture programmer's manual volume 2 system
programming docID #25493" in order to find the official document.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette