linux-kernel - Re: [PATCH v3 08/10] x86/cpufeatures: Add feature bits for AMD heterogeneous processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e41fd460-6b50-4792-9328-3eda370672e4@amd.com>
Date: Tue, 11 Jun 2024 09:31:54 -0500
From: Mario Limonciello <mario.limonciello@....com>
To: Borislav Petkov <bp@...en8.de>, Perry Yuan <perry.yuan@....com>
Cc: gautham.shenoy@....com, rafael.j.wysocki@...el.com,
 viresh.kumar@...aro.org, Ray.Huang@....com, Alexander.Deucher@....com,
 Xinmei.Huang@....com, Xiaojian.Du@....com, Li.Meng@....com,
 linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 08/10] x86/cpufeatures: Add feature bits for AMD
 heterogeneous processor

On 6/11/2024 05:52, Borislav Petkov wrote:
> On Tue, Jun 11, 2024 at 04:52:24PM +0800, Perry Yuan wrote:
>> Subject: Re: [PATCH v3 08/10] x86/cpufeatures: Add feature bits for AMD heterogeneous processor
> 
> "... Add a heterogeneous core topology feature bit"
> 
> not "feature bits"
> 
>> CPUID leaf 0x80000026 advertises core types with different efficiency rankings
>>
>> Bit 30 indicates the heterogeneous core topology feature, if the bit
>> set, it means not all instances at the current hierarchical level have
>> the same core topology.
>>
>> For better utilization of feature words and help to identify core type,
>> X86_FEATURE_HETERO_CORE_TOPOLOGY is added as a few scattered feature bits.
> 
> This sentence is not needed.
> 
>> PDF p274
>>
>> Link: https://www.amd.com/content/dam/amd/en/documents/processor-tech-docs/programmer-references/24593.pdf
> 
> This link will become obsolete, you can say instead
> 
> Search the web for "architecture programmer's manual volume 2 system
> programming docID #25493" in order to find the official document.
> 

Another option is to upload it a non ephemeral location like a kernel 
Bugzilla and link to that.  I do recall there is a bug already opened 
for this purpose in the past.