linux-kernel - Re: [PATCH v5 1/4] mips: bmips: rework and cache CBR addr handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 11 Jun 2024 13:37:10 +0200
From: Christian Marangi <ansuelsmth@...il.com>
To: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc: Hauke Mehrtens <hauke@...ke-m.de>,
	Rafał Miłecki <zajec5@...il.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	linux-mips@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/4] mips: bmips: rework and cache CBR addr handling

On Tue, Jun 11, 2024 at 10:44:16AM +0200, Thomas Bogendoerfer wrote:
> On Sat, May 11, 2024 at 03:03:45PM +0200, Christian Marangi wrote:
> > diff --git a/arch/mips/bmips/setup.c b/arch/mips/bmips/setup.c
> > index 66a8ba19c287..dba789ec75b3 100644
> > --- a/arch/mips/bmips/setup.c
> > +++ b/arch/mips/bmips/setup.c
> > @@ -111,7 +111,7 @@ static void bcm6358_quirks(void)
> >  	 * because the bootloader is not initializing it properly.
> >  	 */
> >  	bmips_rac_flush_disable = !!(read_c0_brcm_cmt_local() & (1 << 31)) ||
> > -				  !!BMIPS_GET_CBR();
> > +				  !!bmips_cbr_addr;
> 
> this hunk doesn't apply to mips-next, please respin.
>

Thanks for pointing this out. Indded a patch was missing and got lost in
sending last revision. I just pushed v6 (and then right after v7 as I
was missing some tag for the DT patch that I forgot to add) that should
add the already reviwed patch.

-- 
	Ansuel