linux-kernel - Re: [PATCH v2 1/5] mfd: axp20x: AXP717: Fix missing IRQ status registers range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56aef347-7582-497e-be02-d82eda7b3528@arm.com>
Date: Wed, 12 Jun 2024 16:07:45 +0100
From: Andre Przywara <andre.przywara@....com>
To: Lee Jones <lee@...nel.org>
Cc: Chen-Yu Tsai <wens@...e.org>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-sunxi@...ts.linux.dev,
 Jernej Skrabec <jernej.skrabec@...il.com>,
 Samuel Holland <samuel@...lland.org>, Ryan Walklin <ryan@...ttoast.com>,
 Chris Morgan <macroalpha82@...il.com>
Subject: Re: [PATCH v2 1/5] mfd: axp20x: AXP717: Fix missing IRQ status
 registers range

Hi Lee,

On 02/05/2024 10:39, Lee Jones wrote:
> On Thu, 18 Apr 2024, Andre Przywara wrote:
> 
>> While we list the "IRQ status *and acknowledge*" registers as volatile,
>> they are missing from the writable range array, so acknowledging any
>> interrupts was met with an -EIO error.
>>
>> Add the five registers that hold those bits to the writable array.
>>
>> Fixes: b5bfc8ab2484 ("mfd: axp20x: Add support for AXP717 PMIC")
>> Reported-by: Chris Morgan <macromorgan@...mail.com>
>> Signed-off-by: Andre Przywara <andre.przywara@....com>
>> ---
>>   drivers/mfd/axp20x.c | 1 +
>>   1 file changed, 1 insertion(+)
> 
> Acked-by: Lee Jones <lee@...nel.org>

Can you please take just this patch as a fix for 6.10? This fixes the 
power key operation.
This applies cleanly on top of v6.10-rc3, so there is no need for any 
extra immutable branch or coordination with regulator.
(The same is true independently for patch 2/5, on the regulator side).

Cheers,
Andre

> 
>> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
>> index 48ce6ea693cea..d8ad4e120d379 100644
>> --- a/drivers/mfd/axp20x.c
>> +++ b/drivers/mfd/axp20x.c
>> @@ -210,6 +210,7 @@ static const struct regmap_access_table axp313a_volatile_table = {
>>   
>>   static const struct regmap_range axp717_writeable_ranges[] = {
>>   	regmap_reg_range(AXP717_IRQ0_EN, AXP717_IRQ4_EN),
>> +	regmap_reg_range(AXP717_IRQ0_STATE, AXP717_IRQ4_STATE),
>>   	regmap_reg_range(AXP717_DCDC_OUTPUT_CONTROL, AXP717_CPUSLDO_CONTROL),
>>   };
>>   
>> -- 
>> 2.35.8
>>
>