linux-kernel - Re: [PATCH 2/2] nvme: fix namespace removal list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5cb2c809-bfa3-4389-8f60-ea0edf742724@nvidia.com>
Date: Wed, 12 Jun 2024 17:20:48 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: Keith Busch <kbusch@...a.com>, "linux-nvme@...ts.infradead.org"
	<linux-nvme@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>
CC: "hch@....de" <hch@....de>, "sagi@...mberg.me" <sagi@...mberg.me>,
	"paulmck@...nel.org" <paulmck@...nel.org>, "davidgow@...gle.com"
	<davidgow@...gle.com>, "akpm@...ux-foundation.org"
	<akpm@...ux-foundation.org>, "venkat88@...ux.vnet.ibm.com"
	<venkat88@...ux.vnet.ibm.com>, Keith Busch <kbusch@...nel.org>
Subject: Re: [PATCH 2/2] nvme: fix namespace removal list

On 6/12/24 08:51, Keith Busch wrote:
> From: Keith Busch<kbusch@...nel.org>
>
> This function wants to move a subset of a list from an element to the
> end to another list, so do that with the new list_cut helper instead of
> using the wrong list splice.
>
> Fixes: be647e2c76b27f4 ("nvme: use srcu for iterating namespace list")
> Reported-by: Venkat Rao Bagalkote<venkat88@...ux.vnet.ibm.com>
> Tested-by: Venkat Rao Bagalkote<venkat88@...ux.vnet.ibm.com>
> Signed-off-by: Keith Busch<kbusch@...nel.org>

not a blocker, but it'd be really useful if we can get a blktests for this,
I've asked OP to provide steps at least ...

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck