linux-kernel - Re: [PATCH 2/2] nvme: fix namespace removal list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZmnZu-QceHYbYf0S@kbusch-mbp.dhcp.thefacebook.com>
Date: Wed, 12 Jun 2024 11:24:11 -0600
From: Keith Busch <kbusch@...nel.org>
To: Chaitanya Kulkarni <chaitanyak@...dia.com>
Cc: Keith Busch <kbusch@...a.com>,
	"linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
	"hch@....de" <hch@....de>, "sagi@...mberg.me" <sagi@...mberg.me>,
	"paulmck@...nel.org" <paulmck@...nel.org>,
	"davidgow@...gle.com" <davidgow@...gle.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"venkat88@...ux.vnet.ibm.com" <venkat88@...ux.vnet.ibm.com>
Subject: Re: [PATCH 2/2] nvme: fix namespace removal list

On Wed, Jun 12, 2024 at 05:20:48PM +0000, Chaitanya Kulkarni wrote:
> On 6/12/24 08:51, Keith Busch wrote:
> > From: Keith Busch<kbusch@...nel.org>
> >
> > This function wants to move a subset of a list from an element to the
> > end to another list, so do that with the new list_cut helper instead of
> > using the wrong list splice.
> >
> > Fixes: be647e2c76b27f4 ("nvme: use srcu for iterating namespace list")
> > Reported-by: Venkat Rao Bagalkote<venkat88@...ux.vnet.ibm.com>
> > Tested-by: Venkat Rao Bagalkote<venkat88@...ux.vnet.ibm.com>
> > Signed-off-by: Keith Busch<kbusch@...nel.org>
> 
> not a blocker, but it'd be really useful if we can get a blktests for this,
> I've asked OP to provide steps at least ...

Recreate the original report: detach the highest namespace id from your
controller. Let's say it's nsid 10, and let's assume your ctrlid is 0:

  # nvme detach-ns /dev/nvme0 -c 0 -n 10

blktests supposedly has something that detaches namespaces through the
nvmet module, but it doesn't seem to be catching anything.