linux-kernel - Re: [PATCH v1 1/2] EDAC/bluefield: fix white space in bluefield_edac_mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240612200056.GGZmn-eO15ePolbAPo@fat_crate.local>
Date: Wed, 12 Jun 2024 22:00:56 +0200
From: Borislav Petkov <bp@...en8.de>
To: David Thompson <davthompson@...dia.com>
Cc: tony.luck@...el.com, james.morse@....com, mchehab@...nel.org,
	rric@...nel.org, shravankr@...dia.com, linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] EDAC/bluefield: fix white space in
 bluefield_edac_mc_probe

On Wed, Jun 12, 2024 at 03:38:30PM -0400, David Thompson wrote:
> This patch removes an empty line in bluefield_edac_mc_probe().

Avoid having "This patch" or "This commit" in the commit message. It is
tautologically useless.

Also, do

$ git grep 'This patch' Documentation/process

for more details.

Also, feel free to peruse that whole directory.

> Signed-off-by: David Thompson <davthompson@...dia.com>
> Reviewed-by: Shravan Kumar Ramani <shravankr@...dia.com>
> ---
>  drivers/edac/bluefield_edac.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/edac/bluefield_edac.c b/drivers/edac/bluefield_edac.c
> index 5b3164560648..1f6f39a7dbf3 100644
> --- a/drivers/edac/bluefield_edac.c
> +++ b/drivers/edac/bluefield_edac.c
> @@ -320,7 +320,6 @@ static int bluefield_edac_mc_probe(struct platform_device *pdev)
>  	edac_mc_free(mci);
>  
>  	return ret;
> -
>  }
>  
>  static void bluefield_edac_mc_remove(struct platform_device *pdev)
> -- 

So just the effort to create a whole patch just for that is an overkill.

Please do not do that. If you notice very minor style issues like that, you can
do them when touching this code as part of a change with more substance. Or you
can simply ignore such minor issues.

Whitespace cleanup like that gets in the way of real work and pretty much all
maintainers are overworked already.

So I'd appreciate it if you concentrate on real fixes and improvements.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette