linux-kernel - RE: [PATCH 01/14] scsi: fnic: Replace shost_printk with pr_info/pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SJ0PR11MB5896A22BC30000E6A0E7CB3BC3C02@SJ0PR11MB5896.namprd11.prod.outlook.com>
Date: Wed, 12 Jun 2024 22:25:35 +0000
From: "Karan Tilak Kumar (kartilak)" <kartilak@...co.com>
To: Hannes Reinecke <hare@...e.de>,
        "Sesidhar Baddela (sebaddel)"
	<sebaddel@...co.com>
CC: "Arulprabhu Ponnusamy (arulponn)" <arulponn@...co.com>,
        "Dhanraj Jhawar
 (djhawar)" <djhawar@...co.com>,
        "Gian Carlo Boffa (gcboffa)"
	<gcboffa@...co.com>,
        "Masa Kai (mkai2)" <mkai2@...co.com>,
        "Satish Kharat
 (satishkh)" <satishkh@...co.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 01/14] scsi: fnic: Replace shost_printk with
 pr_info/pr_err

On Monday, June 10, 2024 11:32 PM, Hannes Reinecke <hare@...e.de> wrote:
>
> On 6/10/24 23:50, Karan Tilak Kumar wrote:
> > Sending host information to shost_printk prior to host initialization
> > in fnic is unnecessary.
> > Replace shost_printk and a printk prior to this initialization with
> > pr_info and pr_err accordingly.
> >
> Please use 'dev_info' and 'dev_err' instead.
> pr_info/pr_err have the problem that they don't reference the device generating the message, making tracking of related messages in a large message log problematic.
>
> Cheers,
>
> Hannes
> --
> Dr. Hannes Reinecke                  Kernel Storage Architect
> hare@...e.de                                +49 911 74053 688
> SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
>
>

Thanks for pointing this out. I'll incorporate this in the next version of changes.

Regards,
Karan