| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <z7wc4oukjnniaafrxgigamsubst5g5slkbfkk43fde7t5bh3eb@pxpmoq6d6da4>
Date: Thu, 13 Jun 2024 00:48:09 +0200
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Nicolas Dufresne <nicolas.dufresne@...labora.com>
Cc: Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
Philipp Zabel <p.zabel@...gutronix.de>, Nicolas Frattaroli <frattaroli.nicolas@...il.com>,
Heiko Stuebner <heiko@...ech.de>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Jianfeng Liu <liujianfeng1994@...il.com>, Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>,
linux-media@...r.kernel.org, linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, kernel@...labora.com
Subject: Re: [PATCH v5 4/5] arm64: dts: rockchip: Add VEPU121 to RK3588
Hi,
On Wed, Jun 12, 2024 at 04:20:57PM GMT, Nicolas Dufresne wrote:
> Hi Sebastian,
>
> Le mercredi 12 juin 2024 à 19:15 +0200, Sebastian Reichel a écrit :
> > From: Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>
> >
> > RK3588 has 4 Hantro G1 encoder-only cores. They are all independent IP,
> > but can be used as a cluster (i.e. sharing work between the cores).
> > These cores are called VEPU121 in the TRM. The TRM describes one more
> > VEPU121, but that is combined with a Hantro H1. That one will be handled
> > using the VPU binding instead.
> >
> > Signed-off-by: Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>
> > ---
> > arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 80 +++++++++++++++++++++++
> > 1 file changed, 80 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> > index 6ac5ac8b48ab..9edbcfe778ca 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> > @@ -1159,6 +1159,86 @@ power-domain@...588_PD_SDMMC {
> > };
> > };
> >
> > + jpeg_enc0: video-codec@...a0000 {
> > + compatible = "rockchip,rk3588-vepu121";
>
> As discussed earlier, VEPU121 is an modifier Hantro H1 encoder core that also
> supports VP8 and H.264 encoding (even though RK vendor kernel only expose them
> for jpeg encoding). The compatible follow this idea, shall we change the alias
> now?
Makes sense. Do you have any preference for the alias Heiko?
Maybe vepu121_0 / vepu121_0_mmu?
-- Sebastian
>
> Nicolas
>
> > + reg = <0x0 0xfdba0000 0x0 0x800>;
> > + interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH 0>;
> > + clocks = <&cru ACLK_JPEG_ENCODER0>, <&cru HCLK_JPEG_ENCODER0>;
> > + clock-names = "aclk", "hclk";
> > + iommus = <&jpeg_enc0_mmu>;
> > + power-domains = <&power RK3588_PD_VDPU>;
> > + };
> > +
> > + jpeg_enc0_mmu: iommu@...a0800 {
> > + compatible = "rockchip,rk3588-iommu", "rockchip,rk3568-iommu";
> > + reg = <0x0 0xfdba0800 0x0 0x40>;
> > + interrupts = <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH 0>;
> > + clocks = <&cru ACLK_JPEG_ENCODER0>, <&cru HCLK_JPEG_ENCODER0>;
> > + clock-names = "aclk", "iface";
> > + power-domains = <&power RK3588_PD_VDPU>;
> > + #iommu-cells = <0>;
> > + };
> > +
> > + jpeg_enc1: video-codec@...a4000 {
> > + compatible = "rockchip,rk3588-vepu121";
> > + reg = <0x0 0xfdba4000 0x0 0x800>;
> > + interrupts = <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH 0>;
> > + clocks = <&cru ACLK_JPEG_ENCODER1>, <&cru HCLK_JPEG_ENCODER1>;
> > + clock-names = "aclk", "hclk";
> > + iommus = <&jpeg_enc1_mmu>;
> > + power-domains = <&power RK3588_PD_VDPU>;
> > + };
> > +
> > + jpeg_enc1_mmu: iommu@...a4800 {
> > + compatible = "rockchip,rk3588-iommu", "rockchip,rk3568-iommu";
> > + reg = <0x0 0xfdba4800 0x0 0x40>;
> > + interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH 0>;
> > + clocks = <&cru ACLK_JPEG_ENCODER1>, <&cru HCLK_JPEG_ENCODER1>;
> > + clock-names = "aclk", "iface";
> > + power-domains = <&power RK3588_PD_VDPU>;
> > + #iommu-cells = <0>;
> > + };
> > +
> > + jpeg_enc2: video-codec@...a8000 {
> > + compatible = "rockchip,rk3588-vepu121";
> > + reg = <0x0 0xfdba8000 0x0 0x800>;
> > + interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH 0>;
> > + clocks = <&cru ACLK_JPEG_ENCODER2>, <&cru HCLK_JPEG_ENCODER2>;
> > + clock-names = "aclk", "hclk";
> > + iommus = <&jpeg_enc2_mmu>;
> > + power-domains = <&power RK3588_PD_VDPU>;
> > + };
> > +
> > + jpeg_enc2_mmu: iommu@...a8800 {
> > + compatible = "rockchip,rk3588-iommu", "rockchip,rk3568-iommu";
> > + reg = <0x0 0xfdba8800 0x0 0x40>;
> > + interrupts = <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH 0>;
> > + clocks = <&cru ACLK_JPEG_ENCODER2>, <&cru HCLK_JPEG_ENCODER2>;
> > + clock-names = "aclk", "iface";
> > + power-domains = <&power RK3588_PD_VDPU>;
> > + #iommu-cells = <0>;
> > + };
> > +
> > + jpeg_enc3: video-codec@...ac000 {
> > + compatible = "rockchip,rk3588-vepu121";
> > + reg = <0x0 0xfdbac000 0x0 0x800>;
> > + interrupts = <GIC_SPI 128 IRQ_TYPE_LEVEL_HIGH 0>;
> > + clocks = <&cru ACLK_JPEG_ENCODER3>, <&cru HCLK_JPEG_ENCODER3>;
> > + clock-names = "aclk", "hclk";
> > + iommus = <&jpeg_enc3_mmu>;
> > + power-domains = <&power RK3588_PD_VDPU>;
> > + };
> > +
> > + jpeg_enc3_mmu: iommu@...ac800 {
> > + compatible = "rockchip,rk3588-iommu", "rockchip,rk3568-iommu";
> > + reg = <0x0 0xfdbac800 0x0 0x40>;
> > + interrupts = <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH 0>;
> > + clocks = <&cru ACLK_JPEG_ENCODER3>, <&cru HCLK_JPEG_ENCODER3>;
> > + clock-names = "aclk", "iface";
> > + power-domains = <&power RK3588_PD_VDPU>;
> > + #iommu-cells = <0>;
> > + };
> > +
> > av1d: video-codec@...70000 {
> > compatible = "rockchip,rk3588-av1-vpu";
> > reg = <0x0 0xfdc70000 0x0 0x800>;
>
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists