linux-kernel - Re: [PATCH v5 5/5] arm64: dts: rockchip: Add VPU121 support for RK3588

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 13 Jun 2024 00:50:12 +0200
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Diederik de Haas <didi.debian@...ow.org>
Cc: Ezequiel Garcia <ezequiel@...guardiasur.com.ar>, 
	Philipp Zabel <p.zabel@...gutronix.de>, Nicolas Frattaroli <frattaroli.nicolas@...il.com>, 
	Heiko Stuebner <heiko@...ech.de>, linux-rockchip@...ts.infradead.org, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Jianfeng Liu <liujianfeng1994@...il.com>, 
	Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>, Nicolas Dufresne <nicolas.dufresne@...labora.com>, 
	linux-media@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	kernel@...labora.com, Hugh Cole-Baker <sigmaris@...il.com>
Subject: Re: [PATCH v5 5/5] arm64: dts: rockchip: Add VPU121 support for
 RK3588

Hi,

On Wed, Jun 12, 2024 at 08:10:30PM GMT, Diederik de Haas wrote:
> On Wednesday, 12 June 2024 19:15:45 CEST Sebastian Reichel wrote:
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> > b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi index
> > 9edbcfe778ca..e7e1b456b9b9 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> > @@ -1239,6 +1239,27 @@ jpeg_enc3_mmu: iommu@...ac800 {
> >                 #iommu-cells = <0>;
> >         };
> > 
> > +       vpu: video-codec@...50000 {
> > +               compatible = "rockchip,rk3588-vpu121",
> > "rockchip,rk3568-vpu"; +               reg = <0x0 0xfdb50000 0x0 0x800>;
> > +               interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH 0>;
> > +               interrupt-names = "vdpu";
> > +               clocks = <&cru ACLK_VPU>, <&cru HCLK_VPU>;
> > +               clock-names = "aclk", "hclk";
> > +               iommus = <&vpu_mmu>;
> > +               power-domains = <&power RK3588_PD_VDPU>;
> > +       };
> > +
> > +       vpu_mmu: iommu@...50800 {
> > +               compatible = "rockchip,rk3588-iommu",
> > "rockchip,rk3568-iommu"; +               reg = <0x0 0xfdb50800 0x0 0x40>;
> > +               interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH 0>;
> > +               clock-names = "aclk", "iface";
> > +               clocks = <&cru ACLK_VPU>, <&cru HCLK_VPU>;
> > +               power-domains = <&power RK3588_PD_VDPU>;
> > +               #iommu-cells = <0>;
> > +       };
> > +
> >         av1d: video-codec@...70000 {
> 
> Shouldn't these nodes come *before* 
> jpeg_enc0: video-codec@...a0000 
> As fdb50000 is lower then fdba0000?

Of course. I will fix that in v6.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)