[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <769ad0d7-57d6-4f1b-a276-5b284380a998@linaro.org>
Date: Wed, 12 Jun 2024 10:03:03 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Raymond Hackley <raymondhackley@...tonmail.com>,
linux-kernel@...r.kernel.org
Cc: Markuss Broks <markuss.broks@...il.com>,
Dmitry Torokhov <dmitry.torokhov@...il.com>, Rob Herring
<robh+dt@...nel.org>, Krzysztof Kozlowski
<krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
Stephan Gerhold <stephan@...hold.net>, Nikita Travkin <nikita@...n.ru>,
linux-input@...r.kernel.org, devicetree@...r.kernel.org,
~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH 2/3] input/touchscreen: imagis: Add supports for Imagis
IST3038
On 12/06/2024 05:21, Raymond Hackley wrote:
> +
> static const struct imagis_properties imagis_3038b_data = {
> - .interrupt_msg_cmd = IST3038B_REG_STATUS,
> - .touch_coord_cmd = IST3038B_REG_STATUS,
> + .interrupt_msg_cmd = IST30XX_REG_STATUS,
> + .touch_coord_cmd = IST30XX_REG_STATUS,
> .whoami_cmd = IST3038B_REG_CHIPID,
> .whoami_val = IST3038B_WHOAMI,
> };
> @@ -415,6 +429,7 @@ static const struct imagis_properties imagis_3038c_data = {
> #ifdef CONFIG_OF
> static const struct of_device_id imagis_of_match[] = {
> { .compatible = "imagis,ist3032c", .data = &imagis_3032c_data },
> + { .compatible = "imagis,ist3038", .data = &imagis_3038_data },
Where is the binding? Compatibles must be documented BEFORE they are used.
Best regards,
Krzysztof
Powered by blists - more mailing lists