| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Jun 2024 12:01:26 +0000 (UTC) From: Kalle Valo <kvalo@...nel.org> To: Wolfram Sang <wsa+renesas@...g-engineering.com> Cc: linux-kernel@...r.kernel.org, Wolfram Sang <wsa+renesas@...g-engineering.com>, Arend van Spriel <arend.vanspriel@...adcom.com>, linux-wireless@...r.kernel.org, brcm80211@...ts.linux.dev, brcm80211-dev-list.pdl@...adcom.com Subject: Re: [PATCH 2/6] wifi: brcmfmac: use 'time_left' variable with wait_event_timeout() Wolfram Sang <wsa+renesas@...g-engineering.com> wrote: > There is a confusing pattern in the kernel to use a variable named 'timeout' to > store the result of wait_event_timeout() causing patterns like: > > timeout = wait_event_timeout(...) > if (!timeout) return -ETIMEDOUT; > > with all kinds of permutations. Use 'time_left' as a variable to make the code > self explaining. > > Fix to the proper variable type 'long' while here. > > Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com> > Acked-by: Arend van Spriel <arend.vanspriel@...adcom.com> 4 patches applied to wireless-next.git, thanks. 158d5a1b3caa wifi: brcmfmac: use 'time_left' variable with wait_event_timeout() 0c0668813cc0 wifi: mwl8k: use 'time_left' variable with wait_for_completion_timeout() a37f6947ff07 wifi: p54: use 'time_left' variable with wait_for_completion_interruptible_timeout() a2ead3445a63 wifi: zd1211rw: use 'time_left' variable with wait_for_completion_timeout() -- https://patchwork.kernel.org/project/linux-wireless/patch/20240603091541.8367-3-wsa+renesas@sang-engineering.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists