linux-kernel - Re: [PATCH 5/6] wifi: rtw89: use 'time_left' variable with wait_for_completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 17 Jun 2024 10:07:00 +0800
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>,
        <linux-kernel@...r.kernel.org>
CC: Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Ping-Ke Shih
	<pkshih@...ltek.com>, Kalle Valo <kvalo@...nel.org>,
        <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH 5/6] wifi: rtw89: use 'time_left' variable with wait_for_completion_timeout()

Wolfram Sang <wsa+renesas@...g-engineering.com> wrote:

> There is a confusing pattern in the kernel to use a variable named 'timeout' to
> store the result of wait_for_completion_timeout() causing patterns like:
> 
> 	timeout = wait_for_completion_timeout(...)
> 	if (!timeout) return -ETIMEDOUT;
> 
> with all kinds of permutations. Use 'time_left' as a variable to make the code
> self explaining.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> Acked-by: Ping-Ke Shih <pkshih@...ltek.com>

1 patch(es) applied to rtw-next branch of rtw.git, thanks.

3d530eeaf8e7 wifi: rtw89: use 'time_left' variable with wait_for_completion_timeout()

---
https://github.com/pkshih/rtw.git