linux-kernel - Re: [PATCH v2] PCI: use local_pci_probe when best selected cpu is offline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 13 Jun 2024 10:20:31 +0800
From: Hongchen Zhang <zhanghongchen@...ngson.cn>
To: Markus Elfring <Markus.Elfring@....de>,
 Huacai Chen <chenhuacai@...ngson.cn>, linux-pci@...r.kernel.org,
 loongarch@...ts.linux.dev, Bjorn Helgaas <bhelgaas@...gle.com>
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] PCI: use local_pci_probe when best selected cpu is
 offline

Hi Markus,
   Thanks for your review.

On 2024/6/13 上午2:08, Markus Elfring wrote:
> …
>> This can be happen if a node is online while all its CPUs are offline
>> (we can use "maxcpus=1" without "nr_cpus=1" to reproduce it), Therefore,
>> in this case, we should call local_pci_probe() instead of work_on_cpu().
> 
> * Please take text layout concerns a bit better into account also according to
>    the usage of paragraphs.
>    https://elixir.bootlin.com/linux/v6.10-rc3/source/Documentation/process/maintainer-tip.rst#L128OK, Let rewrite the commit message.
> * Please improve the change description with an imperative wording.
>    https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc3#n94
OK, Let me use imperative word.
> * Would you like to add the tag “Fixes” accordingly?
OK, Let me add Fixes.
> * How do you think about to specify the name of the affected function
>    in the summary phrase?
OK, Let me add the affected function in summary phrase.

> 
> Regards,
> Markus
> 


-- 
Best Regards
Hongchen Zhang