linux-kernel - Re: [PATCH v5] binder: use bitmap for faster descriptor lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 13 Jun 2024 18:50:53 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Carlos Llamas <cmllamas@...gle.com>, kernel-team@...roid.com,
 Alice Ryhl <aliceryhl@...gle.com>, Arve Hjønnevåg
 <arve@...roid.com>, Christian Brauner <brauner@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Joel Fernandes <joel@...lfernandes.org>, Martijn Coenen <maco@...roid.com>,
 Suren Baghdasaryan <surenb@...gle.com>, Todd Kjos <tkjos@...roid.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Christophe Jaillet <christophe.jaillet@...adoo.fr>,
 John Stultz <jstultz@...gle.com>, Nick Chen <chenjia3@...o.com>,
 Steven Moreland <smoreland@...gle.com>, Tim Murray <timmurray@...gle.com>
Subject: Re: [PATCH v5] binder: use bitmap for faster descriptor lookup

…
> +++ b/drivers/android/binder.c
…
> +static void try_shrink_dmap(struct binder_proc *proc)
> +{
…
> +	binder_proc_lock(proc);
> +	nbits = dbitmap_shrink_nbits(&proc->dmap);
> +	binder_proc_unlock(proc);
…
> +	new = bitmap_zalloc(nbits, GFP_KERNEL);
> +	binder_proc_lock(proc);
> +	dbitmap_shrink(&proc->dmap, new, nbits);
> +	binder_proc_unlock(proc);
> +}
…

Would you become interested to apply lock guards?
https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/cleanup.h#L124

Regards,
Markus