linux-kernel - Re: [PATCH v5] binder: use bitmap for faster descriptor lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024061443-breeding-obvious-908d@gregkh>
Date: Fri, 14 Jun 2024 11:11:48 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Carlos Llamas <cmllamas@...gle.com>, kernel-team@...roid.com,
	Alice Ryhl <aliceryhl@...gle.com>,
	Arve Hjønnevåg <arve@...roid.com>,
	Christian Brauner <brauner@...nel.org>,
	Joel Fernandes <joel@...lfernandes.org>,
	Martijn Coenen <maco@...roid.com>,
	Suren Baghdasaryan <surenb@...gle.com>,
	Todd Kjos <tkjos@...roid.com>, LKML <linux-kernel@...r.kernel.org>,
	Christophe Jaillet <christophe.jaillet@...adoo.fr>,
	John Stultz <jstultz@...gle.com>, Nick Chen <chenjia3@...o.com>,
	Steven Moreland <smoreland@...gle.com>,
	Tim Murray <timmurray@...gle.com>
Subject: Re: [PATCH v5] binder: use bitmap for faster descriptor lookup

On Thu, Jun 13, 2024 at 06:50:53PM +0200, Markus Elfring wrote:
> …
> > +++ b/drivers/android/binder.c
> …
> > +static void try_shrink_dmap(struct binder_proc *proc)
> > +{
> …
> > +	binder_proc_lock(proc);
> > +	nbits = dbitmap_shrink_nbits(&proc->dmap);
> > +	binder_proc_unlock(proc);
> …
> > +	new = bitmap_zalloc(nbits, GFP_KERNEL);
> > +	binder_proc_lock(proc);
> > +	dbitmap_shrink(&proc->dmap, new, nbits);
> > +	binder_proc_unlock(proc);
> > +}
> …
> 
> Would you become interested to apply lock guards?
> https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/cleanup.h#L124

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot