linux-kernel - Re: [PATCH] iio: adc: adi-axi-adc: improve probe() error messaging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57d4659a5abb63d7c085865059b9d71c40371edd.camel@gmail.com>
Date: Fri, 14 Jun 2024 11:11:34 +0200
From: Nuno Sá <noname.nuno@...il.com>
To: Trevor Gamblin <tgamblin@...libre.com>, Lars-Peter Clausen
 <lars@...afoo.de>,  Michael Hennerich <Michael.Hennerich@...log.com>,
 Jonathan Cameron <jic23@...nel.org>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: adi-axi-adc: improve probe() error messaging

On Thu, 2024-06-13 at 12:34 -0400, Trevor Gamblin wrote:
> The current error handling for calls such as devm_clk_get_enabled() in
> the adi-axi-adc probe() function means that, if a property such as
> 'clocks' (for example) is not present in the devicetree when booting a
> kernel with the driver enabled, the resulting error message will be
> vague, e.g.:
> 
> > adi_axi_adc 44a00000.backend: probe with driver adi_axi_adc failed with error -2
> 
> Change the devm_clk_get_enabled(), devm_regmap_init_mmio(), and
> devm_iio_backend_register() checks to use dev_err_probe() with some
> context for easier debugging.
> 
> After the fix:
> 
> > adi_axi_adc 44a00000.backend: error -ENOENT: failed to get clock
> > adi_axi_adc 44a00000.backend: probe with driver adi_axi_adc failed with error -2
> 
> Signed-off-by: Trevor Gamblin <tgamblin@...libre.com>
> ---

Somehow feel that in these cases the error log should come from the functions we're
calling but bah... likely not going happen/change:

Reviewed-by: Nuno Sa <nuno.sa@...log.com>

(As a suggestion, you may do similar work in the axi-dac driver)

- Nuno Sá