linux-kernel - Re: [PATCH 0/6] staging: rtl8192e: Cleanup multiple issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 13 Jun 2024 20:58:06 +0100
From: Teddy Engel <engel.teddy@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>, 
	Philipp Hortmann <philipp.g.hortmann@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-staging@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/6] staging: rtl8192e: Cleanup multiple issues

On Thu, 13 Jun 2024 at 20:22, Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> On Thu, Jun 13, 2024 at 09:05:03PM +0200, Philipp Hortmann wrote:
> > On 6/13/24 17:16, Teddy Engel wrote:
> > > Remove some unused constants, macros, and structs.
> > > Capitalize a constant.
> > >
> > > No specific patch order required.
> > >
> > > Teddy Engel (6):
> > >    staging: rtl8192e: Remove unused constant IC_VersionCut_E
> > >    staging: rtl8192e: Remove unused struct phy_ofdm_rx_status_rxsc
> > >    staging: rtl8192e: Remove unused constant WA_IOT_TH_VAL
> > >    staging: rtl8192e: Capitalize constant RegC38_TH
> > >    staging: rtl8192e: Remove unused macro dm_tx_bb_gain_idx_to_amplify
> > >    staging: rtl8192e: Remove unnecessary pre-declaration of struct
> > >      net_device
> > >
> > >   drivers/staging/rtl8192e/rtl8192e/r8190P_def.h | 8 --------
> > >   drivers/staging/rtl8192e/rtl8192e/rtl_cam.h    | 1 -
> > >   drivers/staging/rtl8192e/rtl8192e/rtl_dm.c     | 4 ++--
> > >   drivers/staging/rtl8192e/rtl8192e/rtl_dm.h     | 6 +-----
> > >   drivers/staging/rtl8192e/rtl8192e/rtl_pci.h    | 1 -
> > >   5 files changed, 3 insertions(+), 17 deletions(-)
> > >
> >
> >
> > Hi Teddy,
> >
> > please combine patch 1 and 3 (Remove unused constant ...) . You can change
> > more than one item in a patch. But it has to be of the same kind.
> >
>
> Could you combine that with the earlier patch that deleted
> IC_VersionCut_C as well?  (Unless that has already been merged).
>
> regards,
> dan carpenter
>

I will, thanks Dan & Philip
Teddy