[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <11b01dd4-79f7-432b-8a43-ec653d60a87b@ti.com>
Date: Thu, 13 Jun 2024 14:24:04 +0530
From: Aradhya Bhatia <a-bhatia1@...com>
To: Jayesh Choudhary <j-choudhary@...com>, <linux-kernel@...r.kernel.org>,
<dmitry.baryshkov@...aro.org>, <sui.jingfeng@...ux.dev>,
<andrzej.hajda@...el.com>, <neil.armstrong@...aro.org>,
<rfoss@...nel.org>, <Laurent.pinchart@...asonboard.com>,
<mripard@...nel.org>, <sam@...nborg.org>
CC: <jonas@...boo.se>, <jernej.skrabec@...il.com>,
<maarten.lankhorst@...ux.intel.com>, <tzimmermann@...e.de>,
<airlied@...il.com>, <daniel@...ll.ch>,
<dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v5 3/3] drm/bridge: sii902x: Add pixel clock check in
atomic_check
On 13-Jun-24 14:08, Jayesh Choudhary wrote:
> Check the pixel clock for the mode in atomic_check and ensure that
> it is within the range supported by the bridge.
>
> Signed-off-by: Jayesh Choudhary <j-choudhary@...com>
> ---
> drivers/gpu/drm/bridge/sii902x.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
> index 00a8c469f553..7f91b0db161e 100644
> --- a/drivers/gpu/drm/bridge/sii902x.c
> +++ b/drivers/gpu/drm/bridge/sii902x.c
> @@ -496,6 +496,10 @@ static int sii902x_bridge_atomic_check(struct drm_bridge *bridge,
> struct drm_crtc_state *crtc_state,
> struct drm_connector_state *conn_state)
> {
> + if (crtc_state->mode.clock < SII902X_MIN_PIXEL_CLOCK_KHZ ||
> + crtc_state->mode.clock > SII902X_MAX_PIXEL_CLOCK_KHZ)
> + return -EINVAL;
> +
> /*
> * There might be flags negotiation supported in future but
> * set the bus flags in atomic_check statically for now.
Reviewed-by: Aradhya Bhatia <a-bhatia1@...com>
--
Regards
Aradhya
Powered by blists - more mailing lists