[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e62a723c-30dc-4667-bbd5-85cb8c583432@kernel.org>
Date: Thu, 13 Jun 2024 12:15:05 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Shresth Prasad <shresthprasad7@...il.com>, vkoul@...nel.org,
kishon@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
heiko@...ech.de, sebastian.reichel@...labora.com, s.hauer@...gutronix.de,
cristian.ciocaltea@...labora.com, andy.yan@...k-chips.com
Cc: linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
linux-kernel@...r.kernel.org, skhan@...uxfoundation.org,
javier.carrasco.cruz@...il.com
Subject: Re: [PATCH v3] dt-bindings: phy: rockchip-emmc-phy: Convert to
dtschema
On 13/06/2024 10:58, Shresth Prasad wrote:
> Convert txt bindings of Rockchip EMMC PHY to dtschema to allow
> for validation.
>
> Signed-off-by: Shresth Prasad <shresthprasad7@...il.com>
> ---
> Changes in v3:
> - fix `reg` in example being too long
>
> Tested against `rockchip/rk3399-firefly.dtb`, `rockchip/rk3399-orangepi.dtb`
> and `rockchip/rk3399-pinebook-pro.dtb`.
>
> .../bindings/phy/rockchip,emmc-phy.yaml | 79 +++++++++++++++++++
> .../bindings/phy/rockchip-emmc-phy.txt | 43 ----------
> .../devicetree/bindings/soc/rockchip/grf.yaml | 2 +-
> 3 files changed, 80 insertions(+), 44 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/phy/rockchip,emmc-phy.yaml
Filename matching compatible.
...
Please look at other bindings how the conversion works and get it
reviewed/acked through your mentors before you post.
> -};
> diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> index 79798c747476..1f88416657cc 100644
> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> @@ -178,7 +178,7 @@ allOf:
> patternProperties:
> "phy@[0-9a-f]+$":
> description:
> - Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
> + Documentation/devicetree/bindings/phy/rockchip,emmc-phy.yaml
Nope, look at the rest of the file and do not implement things differently.
Best regards,
Krzysztof
Powered by blists - more mailing lists