linux-kernel - Re: [PATCH v5 2/2] mm: remove code to handle same filled pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKEwX=NG1kj7oaz08OYoM8Xt1K1Jrg4bgYJozQZ1JXbVC-=vWg@mail.gmail.com>
Date: Fri, 14 Jun 2024 13:25:05 -0700
From: Nhat Pham <nphamcs@...il.com>
To: Usama Arif <usamaarif642@...il.com>
Cc: akpm@...ux-foundation.org, hannes@...xchg.org, shakeel.butt@...ux.dev, 
	david@...hat.com, ying.huang@...el.com, hughd@...gle.com, willy@...radead.org, 
	yosryahmed@...gle.com, chengming.zhou@...ux.dev, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH v5 2/2] mm: remove code to handle same filled pages

On Fri, Jun 14, 2024 at 3:09 AM Usama Arif <usamaarif642@...il.com> wrote:
>
> With an earlier commit to handle zero-filled pages in swap directly,
> and with only 1% of the same-filled pages being non-zero, zswap no
> longer needs to handle same-filled pages and can just work on compressed
> pages.
>
> Signed-off-by: Usama Arif <usamaarif642@...il.com>
> ---

Other than my previous comments to re-add the stat counter somehow
(which will probably helps with testing in the future), this series
LGTM!

Reviewed-by: Nhat Pham <nphamcs@...il.com>