[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0faecb255d7e1e67153321d9009f9fc8c0810cd7.camel@ndufresne.ca>
Date: Fri, 14 Jun 2024 16:30:04 -0400
From: Nicolas Dufresne <nicolas@...fresne.ca>
To: Jeffrey Hugo <quic_jhugo@...cinc.com>, Tomeu Vizoso
<tomeu@...euvizoso.net>, Joerg Roedel <joro@...tes.org>, Will Deacon
<will@...nel.org>, Robin Murphy <robin.murphy@....com>, Heiko Stuebner
<heiko@...ech.de>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
<krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Oded Gabbay
<ogabbay@...nel.org>, Tomeu Vizoso <tomeu.vizoso@...euvizoso.net>, David
Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, Maarten
Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
<mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, Philipp
Zabel <p.zabel@...gutronix.de>, Sumit Semwal <sumit.semwal@...aro.org>,
Christian König <christian.koenig@....com>
Cc: iommu@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org,
linux-media@...r.kernel.org, linaro-mm-sig@...ts.linaro.org
Subject: Re: [PATCH 6/9] accel/rocket: Add a new driver for Rockchip's NPU
Hi,
Le vendredi 14 juin 2024 à 10:16 -0600, Jeffrey Hugo a écrit :
> > + version = rocket_read(core, REG_PC_VERSION) + (rocket_read(core, REG_PC_VERSION_NUM) & 0xffff);
> > + dev_info(rdev->dev, "Rockchip NPU core %d version: %d\n", core->index, version);
>
> A properly working driver should be silent by default.
This is not universally accepted statement. Most drivers do have a one line
"probed/detected" kind of report.
Nicolas
Powered by blists - more mailing lists