linux-kernel - Re: [PATCH net-next 1/2] net: phy: introduce core support for phy-mode = "10g-qxgmii"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f54113a-e2b4-4b7f-91fb-7e60af9ec2cf@quicinc.com>
Date: Fri, 14 Jun 2024 19:42:57 +0800
From: Jie Luo <quic_luoj@...cinc.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <andrew@...n.ch>, <hkallweit1@...il.com>,
        <corbet@....net>, <vladimir.oltean@....com>, <netdev@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-doc@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] net: phy: introduce core support for
 phy-mode = "10g-qxgmii"



On 6/13/2024 3:54 PM, Russell King (Oracle) wrote:
> On Wed, Jun 12, 2024 at 05:53:16PM +0800, Luo Jie wrote:
>> @@ -1865,7 +1872,8 @@ static int phylink_validate_phy(struct phylink *pl, struct phy_device *phy,
>>   	if (phy->is_c45 && state->rate_matching == RATE_MATCH_NONE &&
>>   	    state->interface != PHY_INTERFACE_MODE_RXAUI &&
>>   	    state->interface != PHY_INTERFACE_MODE_XAUI &&
>> -	    state->interface != PHY_INTERFACE_MODE_USXGMII)
>> +	    state->interface != PHY_INTERFACE_MODE_USXGMII &&
>> +	    state->interface != PHY_INTERFACE_MODE_10G_QXGMII)
>>   		state->interface = PHY_INTERFACE_MODE_NA;
> 
> It would be better, rather than extending this workaround, instead to
> have the PHY driver set phy->possible_interfaces in its .config_init
> method. phy->possible_interfaces should be the set of interfaces that
> the PHY _will_ use given its configuration for the different media
> speeds. I think that means just PHY_INTERFACE_MODE_10G_QXGMII for
> your configuration.
> 
> Thanks.
> 

Hi Russell,

Yes, for QCA8084(pure PHY chip), only PHY_INTERFACE_MODE_10G_QXGMII will
be set to the phy->possible_interfaces when it works on the interface
mode PHY_INTERFACE_MODE_10G_QXGMII.

I will push a new patch series to remove PHY_INTERFACE_MODE_10G_QXGMII
from this work-around validation here.

Thanks,
Jie