linux-kernel - Re: [PATCH v5 05/20] leds: leds-lp55xx: generalize load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 16 Jun 2024 12:37:38 +0800
From: kernel test robot <lkp@...el.com>
To: Christian Marangi <ansuelsmth@...il.com>, Pavel Machek <pavel@....cz>,
	Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jacek Anaszewski <jacek.anaszewski@...il.com>,
	linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Christian Marangi <ansuelsmth@...il.com>
Subject: Re: [PATCH v5 05/20] leds: leds-lp55xx: generalize load_engine
 function

Hi Christian,

kernel test robot noticed the following build errors:

[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v6.10-rc3]
[cannot apply to lee-leds/for-leds-next pavel-leds/for-next next-20240613]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Marangi/dt-bindings-leds-lp55xx-limit-pwr-sel-property-to-ti-lp8501/20240616-071915
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20240615231152.28201-6-ansuelsmth%40gmail.com
patch subject: [PATCH v5 05/20] leds: leds-lp55xx: generalize load_engine function
config: i386-buildonly-randconfig-001-20240616 (https://download.01.org/0day-ci/archive/20240616/202406161247.DuuZguPR-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240616/202406161247.DuuZguPR-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406161247.DuuZguPR-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/leds/leds-lp55xx-common.c:103:8: error: call to undeclared function 'FIELD_PREP_CONST'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     103 |         val = LP55xx_MODE_LOAD_ENG << LP55xx_MODE_ENGn_SHIFT(idx, cfg->reg_op_mode.shift);
         |               ^
   drivers/leds/leds-lp55xx-common.c:39:40: note: expanded from macro 'LP55xx_MODE_LOAD_ENG'
      39 | #define   LP55xx_MODE_LOAD_ENG         FIELD_PREP_CONST(LP55xx_MODE_ENG_MASK, 0x1)
         |                                        ^
   1 error generated.


vim +/FIELD_PREP_CONST +103 drivers/leds/leds-lp55xx-common.c

    95	
    96	void lp55xx_load_engine(struct lp55xx_chip *chip)
    97	{
    98		enum lp55xx_engine_index idx = chip->engine_idx;
    99		const struct lp55xx_device_config *cfg = chip->cfg;
   100		u8 mask, val;
   101	
   102		mask = LP55xx_MODE_ENGn_MASK(idx, cfg->reg_op_mode.shift);
 > 103		val = LP55xx_MODE_LOAD_ENG << LP55xx_MODE_ENGn_SHIFT(idx, cfg->reg_op_mode.shift);
   104	
   105		lp55xx_update_bits(chip, cfg->reg_op_mode.addr, mask, val);
   106		lp55xx_wait_opmode_done(chip);
   107	}
   108	EXPORT_SYMBOL_GPL(lp55xx_load_engine);
   109	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki