linux-kernel - Re: [PATCH v5 03/20] leds: leds-lp55xx: generalize stop_all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 16 Jun 2024 12:50:42 +0800
From: kernel test robot <lkp@...el.com>
To: Christian Marangi <ansuelsmth@...il.com>, Pavel Machek <pavel@....cz>,
	Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jacek Anaszewski <jacek.anaszewski@...il.com>,
	linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Christian Marangi <ansuelsmth@...il.com>
Subject: Re: [PATCH v5 03/20] leds: leds-lp55xx: generalize stop_all_engine OP

Hi Christian,

kernel test robot noticed the following build warnings:

[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v6.10-rc3 next-20240613]
[cannot apply to lee-leds/for-leds-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Marangi/dt-bindings-leds-lp55xx-limit-pwr-sel-property-to-ti-lp8501/20240616-071915
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20240615231152.28201-4-ansuelsmth%40gmail.com
patch subject: [PATCH v5 03/20] leds: leds-lp55xx: generalize stop_all_engine OP
config: i386-buildonly-randconfig-004-20240616 (https://download.01.org/0day-ci/archive/20240616/202406161215.GdZijN9e-lkp@intel.com/config)
compiler: gcc-8 (Ubuntu 8.4.0-3ubuntu2) 8.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240616/202406161215.GdZijN9e-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406161215.GdZijN9e-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/leds/leds-lp55xx-common.c: In function 'lp55xx_wait_opmode_done':
>> drivers/leds/leds-lp55xx-common.c:53:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     int ret;
         ^~~


vim +/ret +53 drivers/leds/leds-lp55xx-common.c

    49	
    50	static void lp55xx_wait_opmode_done(struct lp55xx_chip *chip)
    51	{
    52		struct lp55xx_device_config *cfg = chip->cfg;
  > 53		int ret;
    54		u8 val;
    55	
    56		/*
    57		 * Recent chip supports BUSY bit for engine.
    58		 * Check support by checking if val is not 0.
    59		 * For legacy device, sleep at least 153 us.
    60		 */
    61		if (cfg->engine_busy.val)
    62			read_poll_timeout(lp55xx_read, ret, !(val & cfg->engine_busy.mask),
    63					  LP55XX_CMD_SLEEP, LP55XX_CMD_SLEEP * 10, false,
    64					  chip, cfg->engine_busy.addr, &val);
    65		else
    66			usleep_range(LP55XX_CMD_SLEEP, LP55XX_CMD_SLEEP * 2);
    67	}
    68	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki