linux-kernel - Re: [PATCH v3 14/24] genirq/gic-v3-mbi: Remove unused wired MSI mechanics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h6dru0pb.ffs@tglx>
Date: Mon, 17 Jun 2024 16:02:24 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Marc Zyngier <maz@...nel.org>
Cc: Shivamurthy Shastri <shivamurthy.shastri@...utronix.de>,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-pci@...r.kernel.org, anna-maria@...utronix.de, shawnguo@...nel.org,
 s.hauer@...gutronix.de, festevam@...il.com, bhelgaas@...gle.com,
 rdunlap@...radead.org, vidyas@...dia.com, ilpo.jarvinen@...ux.intel.com,
 apatel@...tanamicro.com, kevin.tian@...el.com, nipun.gupta@....com,
 den@...inux.co.jp, andrew@...n.ch, gregory.clement@...tlin.com,
 sebastian.hesselbarth@...il.com, gregkh@...uxfoundation.org,
 rafael@...nel.org, alex.williamson@...hat.com, will@...nel.org,
 lorenzo.pieralisi@....com, jgg@...lanox.com, ammarfaizi2@...weeb.org,
 robin.murphy@....com, lpieralisi@...nel.org, nm@...com, kristo@...nel.org,
 vkoul@...nel.org, okaya@...nel.org, agross@...nel.org,
 andersson@...nel.org, mark.rutland@....com,
 shameerali.kolothum.thodi@...wei.com, yuzenghui@...wei.com
Subject: Re: [PATCH v3 14/24] genirq/gic-v3-mbi: Remove unused wired MSI
 mechanics

On Mon, Jun 17 2024 at 14:03, Marc Zyngier wrote:
> On Mon, 17 Jun 2024 13:55:24 +0100,
> Thomas Gleixner <tglx@...utronix.de> wrote:
>> 
>> On Sat, Jun 15 2024 at 18:24, Marc Zyngier wrote:
>> > On Fri, 14 Jun 2024 11:23:53 +0100,
>> > Shivamurthy Shastri <shivamurthy.shastri@...utronix.de> wrote:
>> >>  static struct msi_domain_info mbi_pmsi_domain_info = {
>> >> -	.flags	= (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
>> >> -		   MSI_FLAG_LEVEL_CAPABLE),
>> >> +	.flags	= (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS),
>> >>  	.ops	= &mbi_pmsi_ops,
>> >>  	.chip	= &mbi_pmsi_irq_chip,
>> >>  };
>> >
>> > This patch doesn't do what it says. It simply kills any form of level
>> > MSI support for *endpoints*, and has nothing to do with any sort of
>> > "wire to MSI".
>> >
>> > What replaces it?
>> 
>> Patch 9/24 switches the wire to MSI with level support over. This just
>> removes the leftovers.
>
> That's not what I read.
>
> Patch 9/24 rewrites the mbigen driver. Which has nothing to do with
> what the gic-v3-mbi code does. They are different blocks, and the sole
> machine that has the mbigen IP doesn't have any gic-v3-mbi support.
> All they have in common are 3 random letters.
>
> What you are doing here is to kill any support for *devices* that need
> to signal level-triggered MSIs in that driver, and nothing to do with
> wire-MSI translation.
>
> So what replaces it?

Hrm. I must have misread this mess. Let me stare some more.