| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 17 Jun 2024 17:07:39 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: oe-kbuild@...ts.linux.dev, Dimitri Fedrau <dima.fedrau@...il.com>
Cc: lkp@...el.com, oe-kbuild-all@...ts.linux.dev,
Dimitri Fedrau <dima.fedrau@...il.com>,
Sebastian Reichel <sre@...nel.org>, linux-kernel@...r.kernel.org,
linux-pm@...r.kernel.org
Subject: Re: [PATCH v3 2/2] power: supply: add support for MAX1720x
standalone fuel gauge
Hi Dimitri,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Dimitri-Fedrau/dt-bindings-power-supply-add-support-for-MAX17201-MAX17205-fuel-gauge/20240616-043602
base: https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
patch link: https://lore.kernel.org/r/20240615203352.164234-3-dima.fedrau%40gmail.com
patch subject: [PATCH v3 2/2] power: supply: add support for MAX1720x standalone fuel gauge
config: nios2-randconfig-r081-20240616 (https://download.01.org/0day-ci/archive/20240617/202406170040.gxB0dYxg-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 13.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
| Closes: https://lore.kernel.org/r/202406170040.gxB0dYxg-lkp@intel.com/
smatch warnings:
drivers/power/supply/max1720x_battery.c:285 max1720x_probe() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +285 drivers/power/supply/max1720x_battery.c
134a669e205435 Dimitri Fedrau 2024-06-15 251 static int max1720x_probe(struct i2c_client *client)
134a669e205435 Dimitri Fedrau 2024-06-15 252 {
134a669e205435 Dimitri Fedrau 2024-06-15 253 struct power_supply_config psy_cfg = {};
134a669e205435 Dimitri Fedrau 2024-06-15 254 struct device *dev = &client->dev;
134a669e205435 Dimitri Fedrau 2024-06-15 255 struct max1720x_device_info *info;
134a669e205435 Dimitri Fedrau 2024-06-15 256 int ret;
134a669e205435 Dimitri Fedrau 2024-06-15 257
134a669e205435 Dimitri Fedrau 2024-06-15 258 info = devm_kzalloc(dev, sizeof(*info), GFP_KERNEL);
134a669e205435 Dimitri Fedrau 2024-06-15 259 if (!info)
134a669e205435 Dimitri Fedrau 2024-06-15 260 return -ENOMEM;
134a669e205435 Dimitri Fedrau 2024-06-15 261
134a669e205435 Dimitri Fedrau 2024-06-15 262 i2c_set_clientdata(client, info);
134a669e205435 Dimitri Fedrau 2024-06-15 263 info->bat_desc.name = "max1720x";
134a669e205435 Dimitri Fedrau 2024-06-15 264 info->bat_desc.no_thermal = true;
134a669e205435 Dimitri Fedrau 2024-06-15 265 info->bat_desc.type = POWER_SUPPLY_TYPE_BATTERY;
134a669e205435 Dimitri Fedrau 2024-06-15 266 info->bat_desc.properties = max1720x_battery_props;
134a669e205435 Dimitri Fedrau 2024-06-15 267 info->bat_desc.num_properties = ARRAY_SIZE(max1720x_battery_props);
134a669e205435 Dimitri Fedrau 2024-06-15 268 info->bat_desc.get_property = max1720x_battery_get_property;
134a669e205435 Dimitri Fedrau 2024-06-15 269 psy_cfg.drv_data = info;
134a669e205435 Dimitri Fedrau 2024-06-15 270
134a669e205435 Dimitri Fedrau 2024-06-15 271 info->regmap = devm_regmap_init_i2c(client, &max1720x_regmap_cfg);
134a669e205435 Dimitri Fedrau 2024-06-15 272 if (IS_ERR(info->regmap))
134a669e205435 Dimitri Fedrau 2024-06-15 273 return dev_err_probe(dev, PTR_ERR(info->regmap),
134a669e205435 Dimitri Fedrau 2024-06-15 274 "regmap initialization failed\n");
134a669e205435 Dimitri Fedrau 2024-06-15 275
134a669e205435 Dimitri Fedrau 2024-06-15 276 info->ancillary = i2c_new_ancillary_device(client, "nvmem", 0xb);
134a669e205435 Dimitri Fedrau 2024-06-15 277 if (IS_ERR(info->ancillary))
134a669e205435 Dimitri Fedrau 2024-06-15 278 return dev_err_probe(dev, PTR_ERR(info->ancillary),
134a669e205435 Dimitri Fedrau 2024-06-15 279 "Failed to initialize ancillary i2c device\n");
134a669e205435 Dimitri Fedrau 2024-06-15 280
134a669e205435 Dimitri Fedrau 2024-06-15 281 i2c_set_clientdata(info->ancillary, info);
134a669e205435 Dimitri Fedrau 2024-06-15 282 ret = max1720x_probe_sense_resistor(info);
134a669e205435 Dimitri Fedrau 2024-06-15 283 if (ret) {
134a669e205435 Dimitri Fedrau 2024-06-15 284 i2c_unregister_device(info->ancillary);
134a669e205435 Dimitri Fedrau 2024-06-15 @285 return dev_err_probe(dev, PTR_ERR(info->bat),
s/PTR_ERR(info->bat)/ret/
134a669e205435 Dimitri Fedrau 2024-06-15 286 "Failed to read sense resistor value\n");
134a669e205435 Dimitri Fedrau 2024-06-15 287 }
134a669e205435 Dimitri Fedrau 2024-06-15 288
134a669e205435 Dimitri Fedrau 2024-06-15 289 info->bat = devm_power_supply_register(dev, &info->bat_desc, &psy_cfg);
134a669e205435 Dimitri Fedrau 2024-06-15 290 if (IS_ERR(info->bat)) {
134a669e205435 Dimitri Fedrau 2024-06-15 291 i2c_unregister_device(info->ancillary);
134a669e205435 Dimitri Fedrau 2024-06-15 292 return dev_err_probe(dev, PTR_ERR(info->bat),
134a669e205435 Dimitri Fedrau 2024-06-15 293 "Failed to register power supply\n");
134a669e205435 Dimitri Fedrau 2024-06-15 294 }
134a669e205435 Dimitri Fedrau 2024-06-15 295
134a669e205435 Dimitri Fedrau 2024-06-15 296 return 0;
134a669e205435 Dimitri Fedrau 2024-06-15 297 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists