linux-kernel - Re: [PATCH v3 1/2] dt-bindings: power: supply: add support for MAX17201/MAX17205 fuel gauge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c9070805-3432-41f8-af1e-dc5e6f81df5c@kernel.org>
Date: Mon, 17 Jun 2024 19:29:36 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dimitri Fedrau <dima.fedrau@...il.com>
Cc: Sebastian Reichel <sre@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: power: supply: add support for
 MAX17201/MAX17205 fuel gauge

On 17/06/2024 14:59, Dimitri Fedrau wrote:
> Am Sun, Jun 16, 2024 at 09:27:21AM +0200 schrieb Krzysztof Kozlowski:
>> On 15/06/2024 22:33, Dimitri Fedrau wrote:
>>> Adding documentation for MAXIMs MAX17201/MAX17205 fuel gauge.
>>>
>>
>> Three patchsets within 30 minutes. No changelog et all.
>>
> Sorry, had to fix my mail address in the commit message. Changelog was
> in the cover letter. Anyway, could have fixed that in a later version.

There was no cover letter attached to this patchset. If you do not send
cover letter to interested parties, then it does not count.

> 
>> Slow down (one posting per 24h) to give people chances to review. Then
>> provide changelog under --- and describe what happened.
>>
> [...]
>>> +maintainers:
>>> +  - Dimitri Fedrau <dima.fedrau@...il.com>
>>> +
>>> +properties:
>>> +      - description: ModelGauge m5 registers
>>> +      - description: Nonvolatile registers
>>> +
>>> +  reg-names:
>>> +    items:
>>> +      - const: m5
>>> +      - const: nvmem
>>> +
>>> +  interrupts:
>>> +    maxItems: 1
>>
>> This is incomplete. Missing battery and probably more... Look how other
>> bindings are written.
>>
> Some fuel gauges used monitored-battery and/or power-supplies others none
> of them(mitsumi,mm8013.yaml). I'm not sure when to use them.

Look at your hardware, datasheet if it is available. Then look at
monitored battery properties. If you see anything in common, then that's
a sign.

I did not get your driver changes, so I cannot help here. Kind of your call.

Best regards,
Krzysztof