[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240617183018.916234-1-andrey.lalaev@gmail.com>
Date: Mon, 17 Jun 2024 20:30:18 +0200
From: Andrei Lalaev <andrey.lalaev@...il.com>
To: dmitry.torokhov@...il.com,
robh@...nel.org,
m.felsch@...gutronix.de
Cc: andrey.lalaev@...il.com,
linux-input@...r.kernel.org,
linux-kernel@...r.kernel.org,
Andrei Lalaev <andrei.lalaev@...on-paar.com>
Subject: [PATCH] Input: qt1050 - handle CHIP_ID reading error
From: Andrei Lalaev <andrei.lalaev@...on-paar.com>
If the device is missing, we get the following error:
qt1050 3-0041: ID -1340767592 not supported
Let's handle this situation and print more informative error
when reading of CHIP_ID fails:
qt1050 3-0041: Failed to read chip ID: -6
Fixes: cbebf5addec1 ("Input: qt1050 - add Microchip AT42QT1050 support")
Signed-off-by: Andrei Lalaev <andrei.lalaev@...on-paar.com>
---
drivers/input/keyboard/qt1050.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/qt1050.c b/drivers/input/keyboard/qt1050.c
index b51dfcd76038..056e9bc26026 100644
--- a/drivers/input/keyboard/qt1050.c
+++ b/drivers/input/keyboard/qt1050.c
@@ -226,7 +226,12 @@ static bool qt1050_identify(struct qt1050_priv *ts)
int err;
/* Read Chip ID */
- regmap_read(ts->regmap, QT1050_CHIP_ID, &val);
+ err = regmap_read(ts->regmap, QT1050_CHIP_ID, &val);
+ if (err) {
+ dev_err(&ts->client->dev, "Failed to read chip ID: %d\n", err);
+ return false;
+ }
+
if (val != QT1050_CHIP_ID_VER) {
dev_err(&ts->client->dev, "ID %d not supported\n", val);
return false;
--
2.35.2
Powered by blists - more mailing lists