linux-kernel - Re: [PATCH v4 4/8] serial: qcom-geni: Fix arg types for qcom_geni_serial_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65f248a7-43bb-4f97-ad98-e2ca29e99e51@linaro.org>
Date: Mon, 17 Jun 2024 20:47:56 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Douglas Anderson <dianders@...omium.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jiri Slaby <jirislaby@...nel.org>
Cc: Yicong Yang <yangyicong@...ilicon.com>, Tony Lindgren <tony@...mide.com>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Johan Hovold <johan+linaro@...nel.org>,
 John Ogness <john.ogness@...utronix.de>, linux-arm-msm@...r.kernel.org,
 Bjorn Andersson <andersson@...nel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Stephen Boyd <swboyd@...omium.org>, linux-serial@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 Vijaya Krishna Nivarthi <quic_vnivarth@...cinc.com>
Subject: Re: [PATCH v4 4/8] serial: qcom-geni: Fix arg types for
 qcom_geni_serial_poll_bit()



On 6/11/24 00:24, Douglas Anderson wrote:
> The "offset" passed in should be unsigned since it's always a positive
> offset from our memory mapped IO.
> 
> The "field" should be u32 since we're anding it with a 32-bit value
> read from the device.
> 
> Suggested-by: Stephen Boyd <swboyd@...omium.org>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad