linux-kernel - Re: [PATCH 2/2] iio: dac: Fix dependencies of AD9739A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19e8a6dd-b0d4-4e88-9ad2-e38787a5aee8@broadcom.com>
Date: Mon, 17 Jun 2024 13:48:38 -0700
From: Alexey Makhalov <alexey.makhalov@...adcom.com>
To: Borislav Petkov <bp@...en8.de>
Cc: linux-kernel@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com,
 lkp@...el.com, zack.rusin@...adcom.com, dri-devel@...ts.freedesktop.org,
 daniel@...ll.ch, airlied@...il.com, tzimmermann@...e.de, mripard@...nel.org,
 maarten.lankhorst@...ux.intel.com, linux-iio@...r.kernel.org,
 jic23@...nel.org, lars@...afoo.de, nuno.sa@...log.com,
 dragos.bogdan@...log.com, anshulusr@...il.com, andrea.collamati@...il.com,
 oe-kbuild-all@...ts.linux.dev, x86@...nel.org
Subject: Re: [PATCH 2/2] iio: dac: Fix dependencies of AD9739A



On 6/17/24 2:04 AM, Borislav Petkov wrote:
> On Sat, Jun 15, 2024 at 06:25:11PM -0700, Alexey Makhalov wrote:
>> 0-DAY CI Kernel Test automation reported an issue:
>>
>>     ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_read':
>>     regmap-spi.c:(.text+0xf): undefined reference to `spi_write_then_read'
>>     ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_gather_write':
>>     regmap-spi.c:(.text+0x2b4): undefined reference to `spi_sync'
>>     ld: drivers/base/regmap/regmap-spi.o: in function `spi_sync_transfer.constprop.0':
>>     regmap-spi.c:(.text+0x337): undefined reference to `spi_sync'
>>     ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_async_write':
>>     regmap-spi.c:(.text+0x445): undefined reference to `spi_async'
>>     ld: drivers/iio/dac/ad9739a.o: in function `ad9739a_driver_init':
>>     ad9739a.c:(.init.text+0x10): undefined reference to `__spi_register_driver'
>>
>> Kconfig warnings: (for reference only)
>>     WARNING: unmet direct dependencies detected for REGMAP_SPI
>>     Depends on [n]: SPI [=n]
>>     Selected by [y]:
>>     - AD9739A [=y] && IIO [=y] && (SPI [=n] || COMPILE_TEST [=y])
>>
>> The issue is caused by CONFIG_AD9739A=y when CONFIG_SPI is not set.
>>
>> Add explicit dependency on SPI and conditional selection of REGMAP_SPI.
>>
>> Fixes: e77603d5468b ("iio: dac: support the ad9739a RF DAC")
>> Reported-by: kernel test robot <lkp@...el.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202406152104.FxakP1MB-lkp@intel.com/
>> Signed-off-by: Alexey Makhalov <alexey.makhalov@...adcom.com>
>> ---
>>   drivers/iio/dac/Kconfig | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
>> index 3c2bf620f00f..d095f4d26e49 100644
>> --- a/drivers/iio/dac/Kconfig
>> +++ b/drivers/iio/dac/Kconfig
>> @@ -133,8 +133,8 @@ config AD5624R_SPI
>>   
>>   config AD9739A
>>   	tristate "Analog Devices AD9739A RF DAC spi driver"
>> -	depends on SPI || COMPILE_TEST
>> -	select REGMAP_SPI
>> +	depends on SPI
>> +	select REGMAP_SPI if SPI_MASTER
>>   	select IIO_BACKEND
>>   	help
>>   	  Say yes here to build support for Analog Devices AD9739A Digital-to
>> -- 
> 
> FWIW, I appreciate it you fixing other breakages. However, there's a patch for
> that already, on its way:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?h=fixes-togreg&id=75183e461ce033605c3e85518a9f3d4e4ef848a3
> 
> Don't get discouraged, though, when fixing something that is not in our
> immediate area of interest!
> 
> :-)
> 
> Thx.
> 

Lesson learned and noted for next time to address only related/new 
warnings and errors. Thanks!