linux-kernel - Re: [PATCH v10 3/6] iio: core: Add new DMABUF interface infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a41fd88-5496-462a-86d2-446c2990fcf7@web.de>
Date: Mon, 17 Jun 2024 08:56:50 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Paul Cercueil <paul@...pouillou.net>, Nuno Sá
 <nuno.sa@...log.com>, linux-iio@...r.kernel.org, dmaengine@...r.kernel.org,
 linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linaro-mm-sig@...ts.linaro.org, Christian König
 <christian.koenig@....com>, Jonathan Cameron <jic23@...nel.org>,
 Lars-Peter Clausen <lars@...afoo.de>, Sumit Semwal
 <sumit.semwal@...aro.org>, Vinod Koul <vkoul@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, linux-doc@...r.kernel.org,
 Jonathan Corbet <corbet@....net>, Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH v10 3/6] iio: core: Add new DMABUF interface
 infrastructure

…
> +++ b/drivers/iio/industrialio-buffer.c
…
>  static int iio_buffer_chrdev_release(struct inode *inode, struct file *filep)
>  {
…
>  	wake_up(&buffer->pollq);
>
> +	mutex_lock(&buffer->dmabufs_mutex);
> +
> +	/* Close all attached DMABUFs */
…
> +	mutex_unlock(&buffer->dmabufs_mutex);
> +
>  	kfree(ib);
…

Would you become interested to apply a statement like “guard(mutex)(&buffer->dmabufs_mutex);”?
https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/mutex.h#L196

Regards,
Markus