linux-kernel - Re: [PATCH v10 3/6] iio: core: Add new DMABUF interface infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <31c868f86d47195e0658eeafc4d6a2cbb9c013ce.camel@crapouillou.net>
Date: Tue, 18 Jun 2024 11:25:52 +0200
From: Paul Cercueil <paul@...pouillou.net>
To: Markus Elfring <Markus.Elfring@....de>, Nuno Sá
 <nuno.sa@...log.com>, linux-iio@...r.kernel.org, dmaengine@...r.kernel.org,
  linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
 linaro-mm-sig@...ts.linaro.org, Christian König
 <christian.koenig@....com>, Jonathan Cameron <jic23@...nel.org>, Lars-Peter
 Clausen <lars@...afoo.de>, Sumit Semwal <sumit.semwal@...aro.org>, Vinod
 Koul <vkoul@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, linux-doc@...r.kernel.org, Jonathan
 Corbet <corbet@....net>, Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH v10 3/6] iio: core: Add new DMABUF interface
 infrastructure

Hi Markus,

Le lundi 17 juin 2024 à 08:56 +0200, Markus Elfring a écrit :
> …
> > +++ b/drivers/iio/industrialio-buffer.c
> …
> >  static int iio_buffer_chrdev_release(struct inode *inode, struct
> > file *filep)
> >  {
> …
> >  	wake_up(&buffer->pollq);
> > 
> > +	mutex_lock(&buffer->dmabufs_mutex);
> > +
> > +	/* Close all attached DMABUFs */
> …
> > +	mutex_unlock(&buffer->dmabufs_mutex);
> > +
> >  	kfree(ib);
> …
> 
> Would you become interested to apply a statement like
> “guard(mutex)(&buffer->dmabufs_mutex);”?
> https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/mutex.h#L196

I'll update the patch to use it.

Cheers,
-Paul