linux-kernel - Re: [PATCH] pinctrl: pistachio: Use scope-based resource management in pistachio_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdanLmWrDD6AdzJJx3fJsQWTE64vh+MjOtDTkpzwqqPkuQ@mail.gmail.com>
Date: Mon, 17 Jun 2024 10:32:03 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Markus Elfring <Markus.Elfring@....de>, Jonathan Cameron <jic23@...nel.org>, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-gpio@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: pistachio: Use scope-based resource management
 in pistachio_gpio_register()

On Wed, Jun 5, 2024 at 6:02 PM Markus Elfring <Markus.Elfring@....de> wrote:

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Wed, 5 Jun 2024 17:46:52 +0200
>
> Scope-based resource management became supported also for another
> programming interface by contributions of Jonathan Cameron on 2024-02-17.
> See also the commit 59ed5e2d505bf5f9b4af64d0021cd0c96aec1f7c ("device
> property: Add cleanup.h based fwnode_handle_put() scope based cleanup.").
>
> * Thus use the attribute “__free(fwnode_handle)”.
>
> * Reduce the scope for the local variable “child”.
>
> * Omit explicit fwnode_handle_put() calls accordingly.
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Looks reasonable but I'd like Jonathan's and Andy's review tags on this.

Yours,
Linus Walleij