linux-kernel - Re: [PATCH] Bluetooth: btusb: Add RTL8852BE device 0489:e125 to device tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <04d3dc7d-8266-4d2d-9efb-e9993af9548b@molgen.mpg.de>
Date: Mon, 17 Jun 2024 10:32:18 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Hilda Wu <hildawu@...ltek.com>, marcel@...tmann.org
Cc: luiz.dentz@...il.com, linux-bluetooth@...r.kernel.org,
 linux-kernel@...r.kernel.org, alex_lu@...lsil.com.cn, max.chou@...ltek.com,
 kidman@...ltek.com
Subject: Re: [PATCH] Bluetooth: btusb: Add RTL8852BE device 0489:e125 to
 device tables

Dear Hilda,


Thank you for your patch.

Am 17.06.24 um 10:21 schrieb Hilda Wu:
> Add the support ID(0489:e125) to usb_device_id table for

Please add a space before (.

> Realtek RTL8852B chip.
> 
> The device info from /sys/kernel/debug/usb/devices as below.

[…]

> Signed-off-by: Hilda Wu <hildawu@...ltek.com>
> ---
>   drivers/bluetooth/btusb.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 79aefdb3324d..2d7d47f9d007 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -555,6 +555,8 @@ static const struct usb_device_id quirks_table[] = {
>   						     BTUSB_WIDEBAND_SPEECH },
>   	{ USB_DEVICE(0x13d3, 0x3572), .driver_info = BTUSB_REALTEK |
>   						     BTUSB_WIDEBAND_SPEECH },
> +	{ USB_DEVICE(0x0489, 0xe125), .driver_info = BTUSB_REALTEK |
> +						     BTUSB_WIDEBAND_SPEECH },

Please put it at the beginning of the list for the 8852BE devices to 
kind of sort it.

>   
>   	/* Realtek 8852BT/8852BE-VT Bluetooth devices */
>   	{ USB_DEVICE(0x0bda, 0x8520), .driver_info = BTUSB_REALTEK |


Kind regards,

Paul