linux-kernel - [PATCH RESEND] drivers/soc/litex: drop obsolete dependency on COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240617104509.70c447b3@endymion.delvare>
Date: Mon, 17 Jun 2024 10:45:09 +0200
From: Jean Delvare <jdelvare@...e.de>
To: LKML <linux-kernel@...r.kernel.org>
Cc: Karol Gugala <kgugala@...micro.com>, Mateusz Holenko
 <mholenko@...micro.com>, Gabriel Somlo <gsomlo@...il.com>, Joel Stanley
 <joel@....id.au>, arnd@...db.de, Andrew Morton <akpm@...ux-foundation.org>
Subject: [PATCH RESEND] drivers/soc/litex: drop obsolete dependency on
 COMPILE_TEST

Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.

It is actually better to always build such drivers with OF enabled,
so that the test builds are closer to how each driver will actually be
built on its intended target. Building them without OF may not test
much as the compiler will optimize out potentially large parts of the
code. In the worst case, this could even pop false positive warnings.
Dropping COMPILE_TEST here improves the quality of our testing and
avoids wasting time on non-existent issues.

As a minor optimization, this also lets us drop of_match_ptr() and
ifdef-guarding, as we now know what they will resolve to, we might as
well save cpp some work.

Signed-off-by: Jean Delvare <jdelvare@...e.de>
Cc: Karol Gugala <kgugala@...micro.com>
Cc: Mateusz Holenko <mholenko@...micro.com>
Cc: Gabriel Somlo <gsomlo@...il.com>
Cc: Joel Stanley <joel@....id.au>
---
Already sent on: 2022-11-24

This is one of the only 3 remaining occurrences of this deprecated
construct.

Arnd, in December 2023, Gabriel suggested that maybe this could go
through one of your trees, as apparently there's no dedicated path to
upstream for litex patches? Thanks in advance.

 drivers/soc/litex/Kconfig          |    2 +-
 drivers/soc/litex/litex_soc_ctrl.c |    4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

--- linux-6.8.orig/drivers/soc/litex/Kconfig
+++ linux-6.8/drivers/soc/litex/Kconfig
@@ -7,7 +7,7 @@ config LITEX

 config LITEX_SOC_CONTROLLER
 	tristate "Enable LiteX SoC Controller driver"
-	depends on OF || COMPILE_TEST
+	depends on OF
 	depends on HAS_IOMEM
 	select LITEX
 	help
--- linux-6.8.orig/drivers/soc/litex/litex_soc_ctrl.c
+++ linux-6.8/drivers/soc/litex/litex_soc_ctrl.c
@@ -82,13 +82,11 @@ static int litex_reset_handler(struct no
 	return NOTIFY_DONE;
 }

-#ifdef CONFIG_OF
 static const struct of_device_id litex_soc_ctrl_of_match[] = {
 	{.compatible = "litex,soc-controller"},
 	{},
 };
 MODULE_DEVICE_TABLE(of, litex_soc_ctrl_of_match);
-#endif /* CONFIG_OF */

 static int litex_soc_ctrl_probe(struct platform_device *pdev)
 {
@@ -130,7 +128,7 @@ static void litex_soc_ctrl_remove(struct
 static struct platform_driver litex_soc_ctrl_driver = {
 	.driver = {
 		.name = "litex-soc-controller",
-		.of_match_table = of_match_ptr(litex_soc_ctrl_of_match)
+		.of_match_table = litex_soc_ctrl_of_match,
 	},
 	.probe = litex_soc_ctrl_probe,
 	.remove_new = litex_soc_ctrl_remove,

-- 
Jean Delvare
SUSE L3 Support