linux-kernel - Re: [PATCH RESEND] drivers/soc/litex: drop obsolete dependency on COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240617105249.5f797a0c@endymion.delvare>
Date: Mon, 17 Jun 2024 10:52:49 +0200
From: Jean Delvare <jdelvare@...e.de>
To: LKML <linux-kernel@...r.kernel.org>
Cc: Karol Gugala <kgugala@...micro.com>, Mateusz Holenko
 <mholenko@...micro.com>, Gabriel Somlo <gsomlo@...il.com>, Joel Stanley
 <joel@....id.au>, arnd@...db.de, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH RESEND] drivers/soc/litex: drop obsolete dependency on
 COMPILE_TEST

On Mon, 17 Jun 2024 10:45:09 +0200, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
> 
> It is actually better to always build such drivers with OF enabled,
> so that the test builds are closer to how each driver will actually be
> built on its intended target. Building them without OF may not test
> much as the compiler will optimize out potentially large parts of the
> code. In the worst case, this could even pop false positive warnings.
> Dropping COMPILE_TEST here improves the quality of our testing and
> avoids wasting time on non-existent issues.
> 
> As a minor optimization, this also lets us drop of_match_ptr() and
> ifdef-guarding, as we now know what they will resolve to, we might as
> well save cpp some work.
> 
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Cc: Karol Gugala <kgugala@...micro.com>
> Cc: Mateusz Holenko <mholenko@...micro.com>
> Cc: Gabriel Somlo <gsomlo@...il.com>
> Cc: Joel Stanley <joel@....id.au>

Sorry, I forgot to update this list with:

Reviewed-by: Gabriel Somlo <gsomlo@...il.com>

(from https://lkml.org/lkml/2023/12/20/1160 )

-- 
Jean Delvare
SUSE L3 Support