linux-kernel - Re: [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240617100150.GDZnAJjoH5wZKu2OAV@fat_crate.local>
Date: Mon, 17 Jun 2024 12:01:50 +0200
From: Borislav Petkov <bp@...en8.de>
To: Zack Rusin <zack.rusin@...adcom.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>
Cc: Alexey Makhalov <alexey.makhalov@...adcom.com>,
	linux-kernel@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com,
	lkp@...el.com, zack.rusin@...adcom.com,
	dri-devel@...ts.freedesktop.org, daniel@...ll.ch, airlied@...il.com,
	tzimmermann@...e.de, mripard@...nel.org,
	maarten.lankhorst@...ux.intel.com, linux-iio@...r.kernel.org,
	jic23@...nel.org, lars@...afoo.de, nuno.sa@...log.com,
	dragos.bogdan@...log.com, anshulusr@...il.com,
	andrea.collamati@...il.com, oe-kbuild-all@...ts.linux.dev,
	x86@...nel.org
Subject: Re: [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency

On Mon, Jun 17, 2024 at 11:07:09AM +0200, Borislav Petkov wrote:
> On Sat, Jun 15, 2024 at 06:25:10PM -0700, Alexey Makhalov wrote:
> > VMWARE_HYPERCALL alternative will not work as intended without
> > VMware guest code initialization.
> > 
> > Reported-by: kernel test robot <lkp@...el.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202406152104.FxakP1MB-lkp@intel.com/
> > Signed-off-by: Alexey Makhalov <alexey.makhalov@...adcom.com>
> > ---
> >  drivers/gpu/drm/vmwgfx/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/vmwgfx/Kconfig b/drivers/gpu/drm/vmwgfx/Kconfig
> > index faddae3d6ac2..6f1ac940cbae 100644
> > --- a/drivers/gpu/drm/vmwgfx/Kconfig
> > +++ b/drivers/gpu/drm/vmwgfx/Kconfig
> > @@ -2,7 +2,7 @@
> >  config DRM_VMWGFX
> >  	tristate "DRM driver for VMware Virtual GPU"
> >  	depends on DRM && PCI && MMU
> > -	depends on X86 || ARM64
> > +	depends on (X86 && HYPERVISOR_GUEST) || ARM64
> >  	select DRM_TTM
> >  	select DRM_TTM_HELPER
> >  	select MAPPING_DIRTY_HELPERS
> > -- 
> 
> Right, I'll queue this soon but it doesn't reproduce here with gcc-11 or gcc-13.
> This must be something gcc-9 specific or so...

Actually, that's a DRM patch.

Folks in To: ok to carry this though the tip tree?

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette