linux-kernel - Re: [PATCH v2 1/1] rtc: tps6594: Add power management support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 18 Jun 2024 17:17:49 +0200
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: Richard GENOUD <richard.genoud@...tlin.com>
Cc: Thomas Richard <thomas.richard@...tlin.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	Udit Kumar <u-kumar1@...com>,
	Gregory CLEMENT <gregory.clement@...tlin.com>,
	Esteban Blanc <eblanc@...libre.com>, linux-rtc@...r.kernel.org,
	Lee Jones <lee@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] rtc: tps6594: Add power management support

On 18/06/2024 11:48:33+0200, Richard GENOUD wrote:
> Le 14/06/2024 à 15:21, Thomas Richard a écrit :
> > > diff --git a/include/linux/mfd/tps6594.h b/include/linux/mfd/tps6594.h
> > > index 3f7c5e23cd4c..85933f1519c4 100644
> > > --- a/include/linux/mfd/tps6594.h
> > > +++ b/include/linux/mfd/tps6594.h
> > > @@ -1011,6 +1011,7 @@ struct tps6594 {
> > >   	bool use_crc;
> > >   	struct regmap *regmap;
> > >   	int irq;
> > > +	int irq_rtc;
> > 
> > irq_rtc should be stored in driver data.
> I understand your point.
> It may indeed be cleaner to separate the rtc-specific data into a private
> struct.
> 
> I'll send a v3 with this modification, and I'll let Alexandre decide which
> he prefers.

My plan is to take v2 as-is


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com