[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c4ce3a14-fb28-4c34-abc1-9b0ae1c1a82f@bootlin.com>
Date: Tue, 18 Jun 2024 11:48:33 +0200
From: Richard GENOUD <richard.genoud@...tlin.com>
To: Thomas Richard <thomas.richard@...tlin.com>,
Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc: Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
Udit Kumar <u-kumar1@...com>, Gregory CLEMENT <gregory.clement@...tlin.com>,
Esteban Blanc <eblanc@...libre.com>, linux-rtc@...r.kernel.org,
Lee Jones <lee@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] rtc: tps6594: Add power management support
Le 14/06/2024 à 15:21, Thomas Richard a écrit :
>> diff --git a/include/linux/mfd/tps6594.h b/include/linux/mfd/tps6594.h
>> index 3f7c5e23cd4c..85933f1519c4 100644
>> --- a/include/linux/mfd/tps6594.h
>> +++ b/include/linux/mfd/tps6594.h
>> @@ -1011,6 +1011,7 @@ struct tps6594 {
>> bool use_crc;
>> struct regmap *regmap;
>> int irq;
>> + int irq_rtc;
>
> irq_rtc should be stored in driver data.
I understand your point.
It may indeed be cleaner to separate the rtc-specific data into a
private struct.
I'll send a v3 with this modification, and I'll let Alexandre decide
which he prefers.
>
>> struct regmap_irq_chip_data *irq_data;
>> };
>>
>
> Thomas
Thanks !
--
Richard Genoud, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Powered by blists - more mailing lists