linux-kernel - Re: [PATCH v4 1/5] mm: add ARCH_SUPPORTS_NON_LEAF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 18 Jun 2024 18:38:24 +0000
From: LEROY Christophe <christophe.leroy2@...soprasteria.com>
To: Maxwell Bland <mbland@...orola.com>, "linux-mm@...ck.org"
	<linux-mm@...ck.org>
CC: Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
	Jonathan Corbet <corbet@....net>, Andrew Morton <akpm@...ux-foundation.org>,
	Ard Biesheuvel <ardb@...nel.org>, Mark Rutland <mark.rutland@....com>,
	Alexandre Ghiti <alexghiti@...osinc.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-doc@...r.kernel.org"
	<linux-doc@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/5] mm: add ARCH_SUPPORTS_NON_LEAF_PTDUMP



Le 18/06/2024 à 16:40, Maxwell Bland a écrit :
> [Vous ne recevez pas souvent de courriers de mbland@...orola.com. D?couvrez pourquoi ceci est important ? https://aka.ms/LearnAboutSenderIdentification ]
> 
> Provide a Kconfig option indicating if note_page can be called for
> intermediate page directories during ptdump.
> 
> Signed-off-by: Maxwell Bland <mbland@...orola.com>
> ---
>   mm/Kconfig.debug |  9 +++++++++
>   mm/ptdump.c      | 21 +++++++++++++--------
>   2 files changed, 22 insertions(+), 8 deletions(-)
> 
> diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug
> index afc72fde0f03..6af5ecfdef93 100644
> --- a/mm/Kconfig.debug
> +++ b/mm/Kconfig.debug
> @@ -201,6 +201,15 @@ config PTDUMP_DEBUGFS
> 
>            If in doubt, say N.
> 
> +config ARCH_SUPPORTS_NON_LEAF_PTDUMP
> +       bool "Include intermediate directory entries in pagetable dumps"
> +       default n
> +       help
> +         Enable the inclusion of intermediate page directory entries in calls
> +         to the ptdump API. Once an architecture defines correct ptdump
> +         behavior for PGD, PUD, P4D, and PMD entries, this config can be
> +         selected.
> +
>   config HAVE_DEBUG_KMEMLEAK
>          bool
> 
> diff --git a/mm/ptdump.c b/mm/ptdump.c
> index 106e1d66e9f9..6180708669fe 100644
> --- a/mm/ptdump.c
> +++ b/mm/ptdump.c
> @@ -41,10 +41,11 @@ static int ptdump_pgd_entry(pgd_t *pgd, unsigned long addr,
>          if (st->effective_prot)
>                  st->effective_prot(st, 0, pgd_val(val));
> 
> -       if (pgd_leaf(val)) {
> +       if (IS_ENABLED(CONFIG_ARCH_SUPPORTS_NON_LEAF_PTDUMP) || pgd_leaf(val))
>                  st->note_page(st, addr, 0, pgd_val(val));
> +
> +       if (pgd_leaf(val))
>                  walk->action = ACTION_CONTINUE;
> -       }
> 
>          return 0;
>   }
> @@ -64,10 +65,11 @@ static int ptdump_p4d_entry(p4d_t *p4d, unsigned long addr,
>          if (st->effective_prot)
>                  st->effective_prot(st, 1, p4d_val(val));
> 
> -       if (p4d_leaf(val)) {
> +       if (IS_ENABLED(CONFIG_ARCH_SUPPORTS_NON_LEAF_PTDUMP) || pgd_leaf(val))

Don't you mean p4d_leaf() here instead of pgd_leaf() ?

>                  st->note_page(st, addr, 1, p4d_val(val));
> +
> +       if (p4d_leaf(val))
>                  walk->action = ACTION_CONTINUE;
> -       }
> 
>          return 0;
>   }
> @@ -87,10 +89,11 @@ static int ptdump_pud_entry(pud_t *pud, unsigned long addr,
>          if (st->effective_prot)
>                  st->effective_prot(st, 2, pud_val(val));
> 
> -       if (pud_leaf(val)) {
> +       if (IS_ENABLED(CONFIG_ARCH_SUPPORTS_NON_LEAF_PTDUMP) || pgd_leaf(val))

Don't you mean pud_leaf() here instead of pgd_leaf() ?

>                  st->note_page(st, addr, 2, pud_val(val));
> +
> +       if (pud_leaf(val))
>                  walk->action = ACTION_CONTINUE;
> -       }
> 
>          return 0;
>   }
> @@ -108,10 +111,12 @@ static int ptdump_pmd_entry(pmd_t *pmd, unsigned long addr,
> 
>          if (st->effective_prot)
>                  st->effective_prot(st, 3, pmd_val(val));
> -       if (pmd_leaf(val)) {
> +
> +       if (IS_ENABLED(CONFIG_ARCH_SUPPORTS_NON_LEAF_PTDUMP) || pgd_leaf(val))

Don't you mean pmd_leaf() here instead of pgd_leaf() ?

>                  st->note_page(st, addr, 3, pmd_val(val));
> +
> +       if (pmd_leaf(val))
>                  walk->action = ACTION_CONTINUE;
> -       }
> 
>          return 0;
>   }
> --
> 2.39.2
> 
>