linux-kernel - Re: [PATCH v4 1/5] mm: add ARCH_SUPPORTS_NON_LEAF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 18 Jun 2024 14:41:11 -0500
From: Maxwell Bland <mbland@...orola.com>
To: LEROY Christophe <christophe.leroy2@...soprasteria.com>
Cc: Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
        Jonathan Corbet <corbet@....net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Ard Biesheuvel <ardb@...nel.org>, Mark Rutland <mark.rutland@....com>,
        Alexandre Ghiti <alexghiti@...osinc.com>,
        "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/5] mm: add ARCH_SUPPORTS_NON_LEAF_PTDUMP

On Tue, Jun 18, 2024 at 06:38:24PM GMT, LEROY Christophe wrote:
> Le 18/06/2024 à 16:40, Maxwell Bland a écrit :
> > @@ -64,10 +65,11 @@ static int ptdump_p4d_entry(p4d_t *p4d, unsigned long addr,
> >          if (st->effective_prot)
> >                  st->effective_prot(st, 1, p4d_val(val));
> > 
> > -       if (p4d_leaf(val)) {
> > +       if (IS_ENABLED(CONFIG_ARCH_SUPPORTS_NON_LEAF_PTDUMP) || pgd_leaf(val))
> 
> Don't you mean p4d_leaf() here instead of pgd_leaf() ?
> Don't you mean pud_leaf() here instead of pgd_leaf() ?
> Don't you mean pmd_leaf() here instead of pgd_leaf() ?

Oh my, this is embarrassing. )-:

Hence the review process---thank you for catching these, will fix in v5.

Maxwell