linux-kernel - Re: [PATCH] mm/migrate: make migrate_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D1935798-D0AB-4624-AAAF-660CCFEBDFD9@nvidia.com>
Date: Tue, 18 Jun 2024 15:48:03 -0400
From: Zi Yan <ziy@...dia.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Hugh Dickins <hughd@...gle.com>, "Huang, Ying" <ying.huang@...el.com>,
 linux-mm@...ck.org, "Matthew Wilcox (Oracle)" <willy@...radead.org>,
 Yang Shi <shy828301@...il.com>, David Hildenbrand <david@...hat.com>,
 Yin Fengwei <fengwei.yin@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/migrate: make migrate_pages_batch() stats consistent.

On 18 Jun 2024, at 15:44, Andrew Morton wrote:

> On Tue, 18 Jun 2024 09:41:51 -0400 Zi Yan <zi.yan@...t.com> wrote:
>
>> From: Zi Yan <ziy@...dia.com>
>>
>> As Ying pointed out in [1], stats->nr_thp_failed needs to be updated to
>> avoid stats inconsistency between MIGRATE_SYNC and MIGRATE_ASYNC when
>> calling migrate_pages_batch().
>>
>
> Thanks.  I'll add
>
> Fixes: 7262f208ca68 ("mm/migrate: split source folio if it is on deferred split list")
>
> and shall queue it for 6.10-rcX.
>
> Please don't forget such details.

I thought about the Fixes tag. Since Hugh's patch fixes the
BUG_ON and VM_BUG_ON, I did not add it here. But yeah stats inconsistency
is something needs to be fixed. Thanks for adding it.

--
Best Regards,
Yan, Zi

Download attachment "signature.asc" of type "application/pgp-signature" (855 bytes)