linux-kernel - Re: [PATCH] mm/migrate: make migrate_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87plsd4co5.fsf@yhuang6-desk2.ccr.corp.intel.com>
Date: Wed, 19 Jun 2024 15:25:14 +0800
From: "Huang, Ying" <ying.huang@...el.com>
To: Zi Yan <zi.yan@...t.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,  Hugh Dickins
 <hughd@...gle.com>,  linux-mm@...ck.org,  Zi Yan <ziy@...dia.com>,
  "Matthew Wilcox (Oracle)" <willy@...radead.org>,  Yang Shi
 <shy828301@...il.com>,  David Hildenbrand <david@...hat.com>,  Yin Fengwei
 <fengwei.yin@...el.com>,  linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/migrate: make migrate_pages_batch() stats consistent.

Zi Yan <zi.yan@...t.com> writes:

> From: Zi Yan <ziy@...dia.com>
>
> As Ying pointed out in [1], stats->nr_thp_failed needs to be updated to
> avoid stats inconsistency between MIGRATE_SYNC and MIGRATE_ASYNC when
> calling migrate_pages_batch().
>
> [1] https://lore.kernel.org/linux-mm/87msnq7key.fsf@yhuang6-desk2.ccr.corp.intel.com/

IMHO, we shouldn't ask people to use link to understand the patch
description or commit message.  If so, we can make the link less
outstanding and maybe add more words about the issue.

> Suggested-by: "Huang, Ying" <ying.huang@...el.com>
> Signed-off-by: Zi Yan <ziy@...dia.com>

Otherwise, LGTM, Thanks!

[snip]

--
Best Regards,
Huang, Ying