linux-kernel - Re: [PATCH] mm/migrate: make migrate_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9D1249AF-CBF9-4283-B1E4-6AF7890C23E0@nvidia.com>
Date: Wed, 19 Jun 2024 14:13:02 -0400
From: Zi Yan <ziy@...dia.com>
To: "Huang, Ying" <ying.huang@...el.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
 Hugh Dickins <hughd@...gle.com>, linux-mm@...ck.org,
 "Matthew Wilcox (Oracle)" <willy@...radead.org>,
 Yang Shi <shy828301@...il.com>, David Hildenbrand <david@...hat.com>,
 Yin Fengwei <fengwei.yin@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/migrate: make migrate_pages_batch() stats consistent.

On 19 Jun 2024, at 3:25, Huang, Ying wrote:

> Zi Yan <zi.yan@...t.com> writes:
>
>> From: Zi Yan <ziy@...dia.com>
>>
>> As Ying pointed out in [1], stats->nr_thp_failed needs to be updated to
>> avoid stats inconsistency between MIGRATE_SYNC and MIGRATE_ASYNC when
>> calling migrate_pages_batch().

Because if not, when migrate_pages_batch() is called via
migrate_pages(MIGRATE_ASYNC), nr_thp_failed will not be increased and
when migrate_pages_batch() is called via migrate_pages(MIGRATE_SYNC*),
nr_thp_failed will be increase in migrate_pages_sync() by
stats->nr_thp_failed += astats.nr_thp_split.

>>
>> [1] https://lore.kernel.org/linux-mm/87msnq7key.fsf@yhuang6-desk2.ccr.corp.intel.com/
>
> IMHO, we shouldn't ask people to use link to understand the patch
> description or commit message.  If so, we can make the link less
> outstanding and maybe add more words about the issue.

I summarized your explanation from the link. You think the summary is not
enough? I can add more text. Let me know if the above text looks
good to you, then I can resend the patch. Thanks.

--
Best Regards,
Yan, Zi

Download attachment "signature.asc" of type "application/pgp-signature" (855 bytes)