linux-kernel - Re: [RFT PATCH v2 2/3] hwmon: (spd5118) Use spd5118 specific read/write operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6999770-c308-4ff1-b667-6095c83c55dc@roeck-us.net>
Date: Tue, 18 Jun 2024 15:37:46 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Paul Menzel <pmenzel@...gen.mpg.de>
Cc: linux-kernel@...r.kernel.org,
 Wolfram Sang <wsa+renesas@...g-engineering.com>,
 René Rebe <rene@...ctcode.de>,
 Thomas Weißschuh <linux@...ssschuh.net>,
 Armin Wolf <W_Armin@....de>, Stephen Horvath <s.horvath@...look.com.au>,
 Sasha Kozachuk <skozachuk@...gle.com>, John Hamrick <johnham@...gle.com>,
 Chris Sarra <chrissarra@...gle.com>, linux-hwmon@...r.kernel.org,
 Jean Delvare <jdelvare@...e.com>
Subject: Re: [RFT PATCH v2 2/3] hwmon: (spd5118) Use spd5118 specific
 read/write operations

Hi Paul,

On 6/18/24 14:45, Paul Menzel wrote:
> Dear Guenter,
> 
> 
> Am 18.06.24 um 23:08 schrieb Guenter Roeck:
> 
>> On 6/18/24 13:37, Paul Menzel wrote:
>> [ ... ]
>>> Unfortunately, it still fails:
>>>
>>>      $ git log --no-decorate --oneline -4
>>>      7ddcff2d44ae3 hwmon: (spd5118) Add support for Renesas/ITD SPD5118 hub controllers
>>>      e89136743324f hwmon: (spd5118) Use spd5118 specific read/write operations
>>>      0fcc7279f0cc4 hwmon: (spd5118) Use regmap to implement paging
>>>      801b6aad6fa7a hwmon: (spd5118) Add configuration option for auto-detection
>>>
>>>      $ uname -r
>>>      6.10.0-rc4.mx64.461-00050-g7ddcff2d44ae
>>>      $ sudo bash -c 'echo 56000 > /sys/class/hwmon/hwmon3/temp1_max'
>>>      bash: line 1: echo: write error: No such device or address
>>
>> Now I am really baffled. I don't think we could do anything simpler
>> than that.
>>
>> Please try
>>      sudo i2cset -y -f 0 0x50 0x21 0x06
>>
>> That should update the critical temperature from 85 degrees C
>> to 86 degrees C. If that doesn't work, we'll be really out of luck
>> with that controller (or at least I don't have an idea what else to try).
> 
> Bad news:
> 
>      $ sudo LD_LIBRARY_PATH=~/src/i2c-tools/lib tools/i2cset -y -f 0 0x50 0x21 0x06
>      Error: Write failed
> 

I wonder if there is some write protect active in your system. I don't see anything
in the spd5118 specification, though, or in the i801 datasheet. I really don't know
what else we could try, sorry. Unfortunately I don't have a system with Intel CPU,
much less one with DDR5, so I won't be able to play with this myself and/or
determine if there is something special with your system, or if this is a generic
problem with i801 controllers.

Let's hope that we get some feedback from others.

Thanks,
Guenter