linux-kernel - Re: [PATCH v3] mtd: spi-nor: simplify spi_nor_get_flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mafs08qz2fur5.fsf@kernel.org>
Date: Tue, 18 Jun 2024 11:46:54 +0200
From: Pratyush Yadav <pratyush@...nel.org>
To: Michael Walle <mwalle@...nel.org>
Cc: Tudor Ambarus <tudor.ambarus@...aro.org>,  Pratyush Yadav
 <pratyush@...nel.org>,  Miquel Raynal <miquel.raynal@...tlin.com>,
  Richard Weinberger <richard@....at>,  Vignesh Raghavendra
 <vigneshr@...com>,  linux-mtd@...ts.infradead.org,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] mtd: spi-nor: simplify spi_nor_get_flash_info()

Hi Michael,

On Mon, Jun 03 2024, Michael Walle wrote:

> Rework spi_nor_get_flash_info() to make it look more straight forward
> and esp. don't return early. The latter is a preparation to check for
> deprecated flashes.
>
> Signed-off-by: Michael Walle <mwalle@...nel.org>

Reviewed-by: Pratyush Yadav <pratyush@...nel.org>

Applied to spi-nor/next. Thanks.

> ---
> v3:
>  - rework the handling quite a bit, thanks Tudor.
>  - drop the spurious comment about the partitions, it goes way back
>    until the initial support. I don't think it's accurate anymore.
>    If the flash has the same size, the partitions can be trusted. If
>    not, anything can happen.. We don't know.
>
> v2/v1:
>  - none, this is a remaining patch of my spring cleanup series.

Do you also plan to re-roll the deprecation patch some time in the
future?

-- 
Regards,
Pratyush Yadav