linux-kernel - Re: [PATCH v1 1/3] dt-bindings: arm: Add binding document for Coresight Slave Register device.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 18 Jun 2024 05:12:35 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Jie Gan <quic_jiegan@...cinc.com>
Cc: Tingwei Zhang <quic_tingweiz@...cinc.com>, linux-kernel@...r.kernel.org, 
 Mathieu Poirier <mathieu.poirier@...aro.org>, 
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>, 
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, 
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, quic_xinlon@...cinc.com, 
 Song Chai <quic_songchai@...cinc.com>, devicetree@...r.kernel.org, 
 linux-arm-msm@...r.kernel.org, Jinlong Mao <quic_jinlmao@...cinc.com>, 
 quic_yanzl@...cinc.com, Tao Zhang <quic_taozha@...cinc.com>, 
 andersson@...nel.org, Suzuki K Poulose <suzuki.poulose@....com>, 
 linux-arm-kernel@...ts.infradead.org, quic_yuanjiey@...cinc.com, 
 Konrad Dybcio <konradybcio@...il.com>, Mike Leach <mike.leach@...aro.org>, 
 Rob Herring <robh+dt@...nel.org>, coresight@...ts.linaro.org, 
 Trilok Soni <quic_tsoni@...cinc.com>, quic_liuxin@...cinc.com, 
 quic_yijiyang@...cinc.com, quic_sijiwu@...cinc.com, 
 quic_xueqnie@...cinc.com, Yuanfang Zhang <quic_yuanfang@...cinc.com>
Subject: Re: [PATCH v1 1/3] dt-bindings: arm: Add binding document for
 Coresight Slave Register device.

On Tue, 18 Jun 2024 15:27:24 +0800, Jie Gan wrote:
> Add binding document for Coresight Slave Register device.
> 
> Add a new property to TMC, qcom,csr-atid-offset, to indicate which
> ATID registers will be used by the TMC ETR. Each TMC ETR device is
> associated with four ATID registers that are continuous in address.
> 
> Signed-off-by: Jie Gan <quic_jiegan@...cinc.com>
> ---
>  .../bindings/arm/arm,coresight-tmc.yaml       |  8 ++
>  .../bindings/arm/qcom,coresight-csr.yaml      | 76 +++++++++++++++++++
>  2 files changed, 84 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/qcom,coresight-csr.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/qcom,coresight-csr.yaml: properties:clock-names: {'maxItems': 1, 'items': [{'const': 'apb_pclk'}]} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
Error: Documentation/devicetree/bindings/arm/qcom,coresight-csr.example.dts:43.3-44.1 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.lib:427: Documentation/devicetree/bindings/arm/qcom,coresight-csr.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240618072726.3767974-2-quic_jiegan@quicinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.