[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240618115845.261297-1-youwan@nfschina.com>
Date: Tue, 18 Jun 2024 19:58:45 +0800
From: Youwan Wang <youwan@...china.com>
To: lpieralisi@...nel.org
Cc: guohanjun@...wei.com,
linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
lenb@...nel.org,
rafael@...nel.org,
sudeep.holla@....com,
linux-acpi@...r.kernel.org,
Youwan Wang <youwan@...china.com>
Subject: [PATCH v3] ACPI /amba: Fix meaningless code for amba_register_dummy_clk()
Defining `amba_dummy_clk` as static is meaningless.
The amba_register_dummy_clk() function is static and
is called during initialization. I think 'amba_dummy_clk'
should be NULL each time when initializing
Signed-off-by: Youwan Wang <youwan@...china.com>
---
drivers/acpi/arm64/amba.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/acpi/arm64/amba.c b/drivers/acpi/arm64/amba.c
index 60be8ee1dbdc..ef438417cc80 100644
--- a/drivers/acpi/arm64/amba.c
+++ b/drivers/acpi/arm64/amba.c
@@ -35,11 +35,7 @@ static const struct acpi_device_id amba_id_list[] = {
static void amba_register_dummy_clk(void)
{
- static struct clk *amba_dummy_clk;
-
- /* If clock already registered */
- if (amba_dummy_clk)
- return;
+ struct clk *amba_dummy_clk;
amba_dummy_clk = clk_register_fixed_rate(NULL, "apb_pclk", NULL, 0, 0);
clk_register_clkdev(amba_dummy_clk, "apb_pclk", NULL);
--
2.25.1
Powered by blists - more mailing lists