linux-kernel - Re: [PATCH v3 2/2] usercopy: Convert test_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e91728af-83e7-453e-816f-add3b0011a66@quicinc.com>
Date: Wed, 19 Jun 2024 11:38:31 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Kees Cook <kees@...nel.org>, Mark Rutland <mark.rutland@....com>
CC: Vitor Massaru Iha <vitor@...saru.org>,
        Ivan Orlov
	<ivan.orlov0322@...il.com>,
        David Gow <davidgow@...gle.com>,
        Brendan Higgins
	<brendan.higgins@...ux.dev>,
        Rae Moar <rmoar@...gle.com>,
        "Gustavo A. R.
 Silva" <gustavoars@...nel.org>,
        <linux-kernel@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
        <kunit-dev@...glegroups.com>, <linux-hardening@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] usercopy: Convert test_user_copy to KUnit test

On 6/12/24 12:59, Kees Cook wrote:
> Convert the runtime tests of hardened usercopy to standard KUnit tests.
> 
> Additionally disable usercopy_test_invalid() for systems with separate
> address spaces (or no MMU) since it's not sensible to test for address
> confusion there (e.g. m68k).
> 
> Co-developed-by: Vitor Massaru Iha <vitor@...saru.org>
> Signed-off-by: Vitor Massaru Iha <vitor@...saru.org>
> Link: https://lore.kernel.org/r/20200721174654.72132-1-vitor@massaru.org
> Tested-by: Ivan Orlov <ivan.orlov0322@...il.com>
> Reviewed-by: David Gow <davidgow@...gle.com>
> Signed-off-by: Kees Cook <kees@...nel.org>
> ---
...
> +kunit_test_suites(&usercopy_test_suite);
> +MODULE_AUTHOR("Kees Cook <kees@...nel.org>");
>   MODULE_LICENSE("GPL");

Can you add the missing MODULE_DESCRIPTION() to remove the W=1 warning?

The fix to the current file is part of:
https://lore.kernel.org/all/20240601-md-lib-test-v1-1-a728620e37d8@quicinc.com/